Skip to content

MINOR: replace NotLeaderForPartitionException with NotLeaderOrFollowerException #9885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 2 commits into from
Jan 14, 2021
+2 −3
Merged

MINOR: replace NotLeaderForPartitionException with NotLeaderOrFollowerException #9885

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79670f
replace the NotLeaderForPartitionException with NotLeaderOrFollowerEx…
showuon Jan 14, 2021
1d5ef15
update based on reviewer's comment
showuon Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/scala/kafka/server/KafkaApis.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,13 +1068,14 @@ class KafkaApis(val requestChannel: RequestChannel,
response
} catch {
// NOTE: These exceptions are special cases since these error messages are typically transient or the client
// would have received a clear exception and there is no value in logging the entire stack trace for the same
// would have received a clear exception.
case e @ (_ : UnknownTopicOrPartitionException |
_ : NotLeaderForPartitionException |
_ : NotLeaderOrFollowerException |
_ : UnknownLeaderEpochException |
_ : FencedLeaderEpochException |
_ : KafkaStorageException |
_ : UnsupportedForMessageFormatException) =>
// print the stack trace for debugging
e.printStackTrace()

@ijuma ijuma Jan 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make much sense, we should not be printing the stacktrace like this.

@showuon showuon Jan 14, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. But I'd like to confirm with @mimaison since he added it in #8295. Thanks.

debug(s"Offset request with correlation id $correlationId from client $clientId on " +
s"partition $topicPartition failed due to ${e.getMessage}")
Expand Down