Skip to content

MINOR: Remove assertDoesNotThrow at last line #9854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 2 commits into from
Jan 13, 2021
Merged

MINOR: Remove assertDoesNotThrow at last line #9854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bf4a76
MINOR: Remove assertDoesNotThrow at last line
g1geordie Jan 10, 2021
8df0704
remove unused import
Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import java.util.concurrent.Future;
import java.util.concurrent.TimeoutException;

import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;

Expand Down Expand Up @@ -140,15 +139,15 @@ public void testSyncSendWithoutIgnoringExceptionsShouldNotThrowException() {
MockKafkaLog4jAppender mockKafkaLog4jAppender = getMockKafkaLog4jAppender();
replaceProducerWithMocked(mockKafkaLog4jAppender, true);

assertDoesNotThrow(() -> logger.error(getMessage(0)));
logger.error(getMessage(0));
}

@Test
public void testRealProducerConfigWithSyncSendShouldNotThrowException() {
Properties props = getLog4jConfigWithRealProducer(true);
PropertyConfigurator.configure(props);

assertDoesNotThrow(() -> logger.error(getMessage(0)));
logger.error(getMessage(0));
}

@Test
Expand Down