Skip to content

MINOR: Remove redundant default parameter values in call to LogSegment.open#9710

Merged
junrao merged 1 commit into
apache:trunkfrom
kowshik:MINOR_remove_default_params_LogSegment.open
Dec 8, 2020
Merged

MINOR: Remove redundant default parameter values in call to LogSegment.open#9710
junrao merged 1 commit into
apache:trunkfrom
kowshik:MINOR_remove_default_params_LogSegment.open

Conversation

@kowshik

@kowshik kowshik commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

Few call sites in Log.scala were passing redundant default values in their calls to LogSegment.open(...). In this PR, I've cleaned these up. For reference, here is a link to the definition of LogSegment.open:

def open(dir: File, baseOffset: Long, config: LogConfig, time: Time, fileAlreadyExists: Boolean = false,
initFileSize: Int = 0, preallocate: Boolean = false, fileSuffix: String = ""): LogSegment = {

Test plan:
Relying on existing unit and integration tests.

@kowshik

kowshik commented Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

cc @junrao @ijuma for review

@junrao junrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kowshik : Thanks for the PR. LGTM

@junrao
junrao merged commit 1d84f54 into apache:trunk Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants