Skip to content

MINOR: remove duplicate code from resetByDuration #9699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 2 commits into from
Dec 10, 2020
Merged

MINOR: remove duplicate code from resetByDuration #9699

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32adca3
MINOR: add a description for calling resetToDatetime's function to re…
bertber Dec 4, 2020
59a8803
remove duplicate code from resetByDuration
bertber Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions core/src/main/scala/kafka/tools/StreamsResetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,17 +491,8 @@ private void resetByDuration(final Consumer<byte[], byte[]> client,
final Duration duration) {
final Instant now = Instant.now();

@chia7712 chia7712 Dec 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove those local variables? For example:

        resetToDatetime(client, inputTopicPartitions, Instant.now().minus(duration).toEpochMilli());

@bertber bertber Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your information. I have updated this problem.

final long timestamp = now.minus(duration).toEpochMilli();

final Map<TopicPartition, Long> topicPartitionsAndTimes = new HashMap<>(inputTopicPartitions.size());
for (final TopicPartition topicPartition : inputTopicPartitions) {
topicPartitionsAndTimes.put(topicPartition, timestamp);
}

final Map<TopicPartition, OffsetAndTimestamp> topicPartitionsAndOffset = client.offsetsForTimes(topicPartitionsAndTimes);

for (final TopicPartition topicPartition : inputTopicPartitions) {
client.seek(topicPartition, topicPartitionsAndOffset.get(topicPartition).offset());
}

resetToDatetime(client, inputTopicPartitions, timestamp);
}

private void resetToDatetime(final Consumer<byte[], byte[]> client,
Expand Down