Skip to content

MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 1 commit into from
Dec 3, 2020
Merged

MINOR: Fix flaky test shouldQueryOnlyActivePartitionStoresByDefault #9681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,13 @@ public void shouldQueryOnlyActivePartitionStoresByDefault() throws Exception {

final boolean kafkaStreams1IsActive = (keyQueryMetadata.activeHost().port() % 2) == 1;

// Assert that only active is able to query for a key by default
assertThat(kafkaStreams1IsActive ? store1.get(key) : store2.get(key), is(notNullValue()));

@cadonna cadonna Dec 3, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time we forgot to move this line into the try-catch-clause.

try {
if (kafkaStreams1IsActive) {
assertThat(store1.get(key), is(notNullValue()));
assertThat(store2.get(key), is(nullValue()));
} else {
assertThat(store1.get(key), is(nullValue()));
assertThat(store2.get(key), is(notNullValue()));
}

@cadonna cadonna Dec 3, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this is easier readable.

return true;
} catch (final InvalidStateStoreException exception) {
Expand Down