MINOR: Do not print log4j for memberId required#9667
Conversation
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@guozhangwang Nice improvement. It makes sense to me to eliminate this "error message" as it is NOT fatal.
| final RuntimeException exception = future.exception(); | ||
| log.info("Rebalance failed.", exception); | ||
|
|
||
| if (!(exception instanceof MemberIdRequiredException)) { |
There was a problem hiding this comment.
Is JoinGroupResponseHandler a better place to log error? For example, the error UNKNOWN_MEMBER_ID is log twice.
(https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java#L605)
There was a problem hiding this comment.
For another, does it need some comment to explain why MemberIdRequiredException is excluded.
There was a problem hiding this comment.
I think I agree with you: it is a bit redundant. I think originally it is because this future may contain the error that is either from join-response or from sync-response, but at the moment both errors are logged inside the Join/SyncGroupHandler anyways. Just to maintain compatibility in case some trouble shooting scenarios are dependent on this summary entry for now.
abbccdda
left a comment
abbccdda
left a comment
There was a problem hiding this comment.
Maybe add an explanation here for why to skip the member.id required exception? (as it's transient)
Ack, will do. |
For MemberIdRequiredException, we would not print the exception at INFO with a full exception message since it may introduce more confusion that clearance. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Boyang Chen <boyang@confluent.io>
For MemberIdRequiredException, we would not print the exception at INFO with a full exception message since it may introduce more confusion that clearance. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Boyang Chen <boyang@confluent.io>
|
cherry-picked to 2.7 |
4 participants
For MemberIdRequiredException, we would not print the exception at INFO with a full exception message since it may introduce more confusion that clearance.
Committer Checklist (excluded from commit message)