Skip to content

MINOR: Remove redundant argument from TaskMetricsGroup#recordCommit #9642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 1 commit into from
Nov 24, 2020
Merged

MINOR: Remove redundant argument from TaskMetricsGroup#recordCommit #9642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ protected void recordActiveTopic(String topic) {
* @param duration the length of time in milliseconds for the commit attempt to complete
*/
protected void recordCommitSuccess(long duration) {
taskMetricsGroup.recordCommit(duration, true, null);
taskMetricsGroup.recordCommit(duration, null);
}

/**
Expand All @@ -308,7 +308,7 @@ protected void recordCommitSuccess(long duration) {
* @param error the unexpected error that occurred; may be null in the case of timeouts or interruptions
*/
protected void recordCommitFailure(long duration, Throwable error) {
taskMetricsGroup.recordCommit(duration, false, error);
taskMetricsGroup.recordCommit(duration, error);
}

/**
Expand Down Expand Up @@ -385,8 +385,8 @@ void close() {
metricGroup.close();
}

void recordCommit(long duration, boolean success, Throwable error) {
if (success) {
void recordCommit(long duration, Throwable error) {
if (error == null) {
commitTime.record(duration);
commitAttempts.record(1.0d);
} else {
Expand Down