-
Notifications
You must be signed in to change notification settings - Fork 15.4k
KAFKA-10394: generate snapshot #9512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hachikuji
merged 15 commits into
apache:trunk
from
jsancio:kafka-10394-generate-snapshot
Dec 7, 2020
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
91bce7e
KAFKA-10394: Generate Kafka Snapshots
jsancio 455e362
Implement a buffered snapshot writer
jsancio 00ea9fd
Simplify some tests
jsancio 5ac347d
Support appending bytes directly to the snapshot
jsancio a3cc586
Rename snapshot writing to BatchedSnapshotWriter
jsancio 288b19f
Merge remote-tracking branch 'upstream/trunk' into kafka-10394-genera…
jsancio b054197
Move snapshot implementations to raft project
jsancio 5c85536
Rename the snapshot classes and interfaces
jsancio 303c300
Improve documentation
jsancio db59168
Change the epoch formatter
jsancio 408d0b7
Merge remote-tracking branch 'upstream/trunk' into kafka-10394-genera…
jsancio 9c7b8e4
Merge remote-tracking branch 'upstream/trunk' into kafka-10394-genera…
jsancio 10f1d5c
Store snapshots directly in the partition directory
jsancio aa500b9
Always attempt to delete the temporary snapshot file
jsancio f853c50
Use `atomicMoveWithFallback`
hachikuji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
core/src/main/scala/kafka/snapshot/KafkaSnapshotReader.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package kafka.snapshot | ||
|
|
||
| import java.nio.ByteBuffer | ||
| import java.nio.file.Path | ||
| import java.util.{Iterator => JIterator} | ||
| import org.apache.kafka.common.record.RecordBatch | ||
| import org.apache.kafka.common.record.FileRecords | ||
| import org.apache.kafka.raft.OffsetAndEpoch | ||
| import org.apache.kafka.snapshot.SnapshotReader | ||
|
|
||
| final class KafkaSnapshotReader private (fileRecords: FileRecords, snapshotId: OffsetAndEpoch) extends SnapshotReader { | ||
| def snapshotId(): OffsetAndEpoch = { | ||
| snapshotId | ||
| } | ||
|
|
||
| def sizeInBytes(): Long = { | ||
| fileRecords.sizeInBytes() | ||
| } | ||
|
|
||
| def iterator(): JIterator[RecordBatch] = { | ||
| new JIterator[RecordBatch] { | ||
| private[this] val iterator = fileRecords.batchIterator() | ||
|
|
||
| override def hasNext(): Boolean = { | ||
| iterator.hasNext() | ||
| } | ||
|
|
||
| override def next(): RecordBatch = { | ||
| iterator.next() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| def read(buffer: ByteBuffer, position: Long): Int = { | ||
| fileRecords.channel.read(buffer, position) | ||
| } | ||
|
|
||
| def close(): Unit = { | ||
| fileRecords.close() | ||
| } | ||
| } | ||
|
|
||
| object KafkaSnapshotReader { | ||
| def apply(logDir: Path, snapshotId: OffsetAndEpoch): KafkaSnapshotReader = { | ||
| val fileRecords = FileRecords.open( | ||
| snapshotPath(logDir, snapshotId).toFile, | ||
| false, // mutable | ||
| true, // fileAlreadyExists | ||
| 0, // initFileSize | ||
| false // preallocate | ||
| ) | ||
|
|
||
| new KafkaSnapshotReader(fileRecords, snapshotId) | ||
| } | ||
| } | ||
95 changes: 95 additions & 0 deletions
95
core/src/main/scala/kafka/snapshot/KafkaSnapshotWriter.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package kafka.snapshot | ||
|
|
||
| import java.nio.ByteBuffer | ||
| import java.nio.channels.FileChannel | ||
| import java.nio.file.Files | ||
| import java.nio.file.Path | ||
| import java.nio.file.StandardCopyOption | ||
| import java.nio.file.StandardOpenOption | ||
| import kafka.utils.Logging | ||
| import org.apache.kafka.common.record.MemoryRecords | ||
| import org.apache.kafka.common.utils.Utils | ||
| import org.apache.kafka.raft.OffsetAndEpoch | ||
| import org.apache.kafka.snapshot.SnapshotWriter | ||
|
|
||
| final class KafkaSnapshotWriter( | ||
| path: Path, | ||
| channel: FileChannel, | ||
| snapshotId: OffsetAndEpoch | ||
| ) extends SnapshotWriter with Logging { | ||
| private[this] var frozen = false | ||
|
|
||
| override def snapshotId(): OffsetAndEpoch = { | ||
| snapshotId | ||
| } | ||
|
|
||
| override def sizeInBytes(): Long = { | ||
| channel.size() | ||
| } | ||
|
|
||
| override def append(records: MemoryRecords): Int = { | ||
| if (frozen) { | ||
| throw new IllegalStateException(s"Append not supported. Snapshot is already frozen: id = $snapshotId; path = $path") | ||
| } | ||
|
|
||
| records.writeFullyTo(channel) | ||
| } | ||
|
|
||
| override def append(buffer: ByteBuffer): Unit = { | ||
| if (frozen) { | ||
| throw new IllegalStateException(s"Append not supported. Snapshot is already frozen: id = $snapshotId; path = $path") | ||
| } | ||
|
|
||
| Utils.writeFully(channel, buffer) | ||
| } | ||
|
|
||
| override def isFrozen(): Boolean = { | ||
| frozen | ||
| } | ||
|
|
||
| override def freeze(): Unit = { | ||
| channel.close() | ||
| frozen = true | ||
|
|
||
| // Set readonly and ignore the result | ||
| if (!path.toFile.setReadOnly()) { | ||
| info(s"Unable to change permission to readonly for internal snapshot file '$path'") | ||
| } | ||
|
|
||
| val destination = moveRename(path, snapshotId) | ||
| Files.move(path, destination, StandardCopyOption.ATOMIC_MOVE) | ||
| } | ||
|
|
||
| override def close(): Unit = { | ||
| channel.close() | ||
| Files.deleteIfExists(path) | ||
| } | ||
| } | ||
|
|
||
| object KafkaSnapshotWriter { | ||
| def apply(logDir: Path, snapshotId: OffsetAndEpoch): KafkaSnapshotWriter = { | ||
| val path = createTempFile(logDir, snapshotId) | ||
|
|
||
| new KafkaSnapshotWriter( | ||
| path, | ||
| FileChannel.open(path, Utils.mkSet(StandardOpenOption.WRITE, StandardOpenOption.APPEND)), | ||
| snapshotId | ||
| ) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package kafka | ||
|
|
||
| import java.nio.file.Files | ||
| import java.nio.file.Path | ||
| import java.text.NumberFormat | ||
| import org.apache.kafka.raft.OffsetAndEpoch | ||
|
|
||
| package object snapshot { | ||
| private[this] val SnapshotDir = "snapshots" | ||
| private[this] val Suffix = ".snapshot" | ||
| private[this] val PartialSuffix = s"$Suffix.part" | ||
|
|
||
| def snapshotDir(logDir: Path): Path = { | ||
| logDir.resolve(SnapshotDir) | ||
| } | ||
|
|
||
| def snapshotPath(logDir: Path, snapshotId: OffsetAndEpoch): Path = { | ||
| snapshotDir(logDir).resolve(filenameFromSnapshotId(snapshotId) + Suffix) | ||
| } | ||
|
|
||
| def filenameFromSnapshotId(snapshotId: OffsetAndEpoch): String = { | ||
| val formatter = NumberFormat.getInstance() | ||
| formatter.setMinimumIntegerDigits(20) | ||
| formatter.setGroupingUsed(false) | ||
|
|
||
| formatter.format(snapshotId.offset) + "-" + formatter.format(snapshotId.epoch) | ||
| } | ||
|
|
||
| def moveRename(source: Path, snapshotId: OffsetAndEpoch): Path = { | ||
| source.resolveSibling(filenameFromSnapshotId(snapshotId) + Suffix) | ||
| } | ||
|
|
||
| def createTempFile(logDir: Path, snapshotId: OffsetAndEpoch): Path = { | ||
| val dir = snapshotDir(logDir) | ||
|
|
||
| // Create the snapshot directory if it doesn't exists | ||
| Files.createDirectories(dir) | ||
|
|
||
| val prefix = s"${filenameFromSnapshotId(snapshotId)}-" | ||
|
|
||
| Files.createTempFile(dir, prefix, PartialSuffix) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.