-
Notifications
You must be signed in to change notification settings - Fork 15.4k
KAFKA-10394: generate snapshot #9512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hachikuji
merged 15 commits into
apache:trunk
from
jsancio:kafka-10394-generate-snapshot
Dec 7, 2020
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
91bce7e
KAFKA-10394: Generate Kafka Snapshots
jsancio 455e362
Implement a buffered snapshot writer
jsancio 00ea9fd
Simplify some tests
jsancio 5ac347d
Support appending bytes directly to the snapshot
jsancio a3cc586
Rename snapshot writing to BatchedSnapshotWriter
jsancio 288b19f
Merge remote-tracking branch 'upstream/trunk' into kafka-10394-genera…
jsancio b054197
Move snapshot implementations to raft project
jsancio 5c85536
Rename the snapshot classes and interfaces
jsancio 303c300
Improve documentation
jsancio db59168
Change the epoch formatter
jsancio 408d0b7
Merge remote-tracking branch 'upstream/trunk' into kafka-10394-genera…
jsancio 9c7b8e4
Merge remote-tracking branch 'upstream/trunk' into kafka-10394-genera…
jsancio 10f1d5c
Store snapshots directly in the partition directory
jsancio aa500b9
Always attempt to delete the temporary snapshot file
jsancio f853c50
Use `atomicMoveWithFallback`
hachikuji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotReader.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.snapshot; | ||
|
|
||
| import java.io.IOException; | ||
| import java.nio.ByteBuffer; | ||
| import java.nio.file.Path; | ||
| import java.util.Iterator; | ||
| import org.apache.kafka.common.record.FileLogInputStream.FileChannelRecordBatch; | ||
| import org.apache.kafka.common.record.FileRecords; | ||
| import org.apache.kafka.common.record.RecordBatch; | ||
| import org.apache.kafka.common.utils.AbstractIterator; | ||
| import org.apache.kafka.raft.OffsetAndEpoch; | ||
|
|
||
| public final class FileRawSnapshotReader implements RawSnapshotReader { | ||
| private final FileRecords fileRecords; | ||
| private final OffsetAndEpoch snapshotId; | ||
|
|
||
| private FileRawSnapshotReader(FileRecords fileRecords, OffsetAndEpoch snapshotId) { | ||
| this.fileRecords = fileRecords; | ||
| this.snapshotId = snapshotId; | ||
| } | ||
|
|
||
| @Override | ||
| public OffsetAndEpoch snapshotId() { | ||
| return snapshotId; | ||
| } | ||
|
|
||
| @Override | ||
| public long sizeInBytes() { | ||
| return fileRecords.sizeInBytes(); | ||
| } | ||
|
|
||
| @Override | ||
| public Iterator<RecordBatch> iterator() { | ||
| return new Iterator<RecordBatch>() { | ||
|
jsancio marked this conversation as resolved.
Outdated
|
||
| private final AbstractIterator<FileChannelRecordBatch> iterator = fileRecords.batchIterator(); | ||
|
|
||
| @Override | ||
| public boolean hasNext() { | ||
| return iterator.hasNext(); | ||
| } | ||
|
|
||
| @Override | ||
| public RecordBatch next() { | ||
| return iterator.next(); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| @Override | ||
| public int read(ByteBuffer buffer, long position) throws IOException { | ||
| return fileRecords.channel().read(buffer, position); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() throws IOException { | ||
| fileRecords.close(); | ||
| } | ||
|
|
||
| /** | ||
| * Opens a snapshot for reading. | ||
| * | ||
| * @param logDir the directory for the topic partition | ||
| * @param snapshotId the end offset and epoch for the snapshotId | ||
| * @throws java.nio.file.NoSuchFileException if the snapshot doesn't exist | ||
| * @throws IOException for any IO error while opening the snapshot | ||
| */ | ||
| public static FileRawSnapshotReader open(Path logDir, OffsetAndEpoch snapshotId) throws IOException { | ||
| FileRecords fileRecords = FileRecords.open( | ||
| Snapshots.snapshotPath(logDir, snapshotId).toFile(), | ||
| false, // mutable | ||
| true, // fileAlreadyExists | ||
| 0, // initFileSize | ||
| false // preallocate | ||
| ); | ||
|
|
||
| return new FileRawSnapshotReader(fileRecords, snapshotId); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.