Skip to content

KAFKA-10460: ReplicaListValidator format checking is incomplete #9326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 3 commits into from
Dec 3, 2020
Merged

KAFKA-10460: ReplicaListValidator format checking is incomplete #9326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08a93ac
KAFKA-10460: ReplicaListValidator format checking is incomplete
Sep 23, 2020
cdfc190
KAFKA-10460: ReplicaListValidator format checking is incomplete
Oct 1, 2020
301c6f5
Adding test for KAFKA-10460
Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/kafka/server/ConfigHandler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ object ThrottledReplicaListValidator extends Validator {
override def ensureValid(name: String, value: Any): Unit = {
def check(proposed: Seq[Any]): Unit = {
if (!(proposed.forall(_.toString.trim.matches("([0-9]+:[0-9]+)?"))
|| proposed.headOption.exists(_.toString.trim.equals("*"))))
|| proposed.mkString.trim.equals("*")))
throw new ConfigException(name, value,
s"$name must be the literal '*' or a list of replicas in the following format: [partitionId]:[brokerId],[partitionId]:[brokerId],...")
}
Expand Down
2 changes: 2 additions & 0 deletions core/src/test/scala/unit/kafka/log/LogConfigTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ class LogConfigTest {
assertFalse(isValid("100 :0,10: "))
assertFalse(isValid("100: 0,10: "))
assertFalse(isValid("100:0,10 : "))
assertFalse(isValid("*,100:10"))
assertFalse(isValid("* ,100:10"))
}

/* Sanity check that toHtmlTable produces one of the expected configs */
Expand Down