KAFKA-10407: Have KafkaLog4jAppender support linger.ms and batch.size#9189
Merged
Conversation
added 2 commits
August 17, 2020 10:15
https://issues.apache.org/jira/browse/KAFKA-10407 Currently, KafkaLog4jAppender does not support `batch.size` or `linger.ms` which would otherwise be beneficial in some situations.
huxihx
changed the title
linger.ms and batch.sizelinger.ms and batch.size
dongjinleekr
approved these changes
Aug 17, 2020
Contributor
|
Hi @huxihx, It seems like this feature requires a KIP. Isn't it? |
Contributor
Author
|
@dongjinleekr Thanks for the comments. I think it needs no KIP for this patch, since it does not break any compatibility. It's totally okay for you not to specify them when using KafkaLog4jAppender. Besides, |
Contributor
Contributor
Author
|
@omkreddy Thanks for the review, merging to trunk. @dongjinleekr Thanks for the comments again. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-10407
Currently, KafkaLog4jAppender does not support
linger.msorbatch.size. In some situations, those two parameters are good to tune the performance.More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)