KAFKA-10146, KAFKA-9066: Retain metrics for failed tasks (backport to 2.4)#9106
Merged
Conversation
Author: Chris Egerton <chrise@confluent.io> Reviewers: Nigel Liang <nigel@nigelliang.com>, Randall Hauch <rhauch@gmail.com>
3 tasks
rhauch
changed the title
Contributor
Author
|
@kkonstantine, here is a PR for the |
kkonstantine
approved these changes
Jul 30, 2020
kkonstantine
left a comment
kkonstantine
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rhauch
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets the
2.4branch. See #8854 for the similar PR for the2.5branch, which is currently blocked by the 2.5.1 release effort.This backports the KAFKA-9066 / #8502 changes to retain metrics for failed tasks that was already merged to trunk and backported to the 2.6 branch.
Like #8854, this PR has one change relative to the original PR: it removes an integration test added in the 2.6 branch for KIP-158 and modified as part of KAFKA-9066 / #8502.
Author: Chris Egerton chrise@confluent.io
Reviewers: Nigel Liang nigel@nigelliang.com, Randall Hauch rhauch@gmail.com
Committer Checklist (excluded from commit message)