Skip to content

MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACT… #9077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbccdda merged 1 commit into from
Jul 27, 2020
Merged

MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACT… #9077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions clients/src/main/java/org/apache/kafka/clients/admin/NewTopic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import org.apache.kafka.common.message.CreateTopicsRequestData.CreatableReplicaAssignment;
import org.apache.kafka.common.message.CreateTopicsRequestData.CreatableTopic;
import org.apache.kafka.common.message.CreateTopicsRequestData.CreateableTopicConfig;
import org.apache.kafka.common.requests.CreateTopicsRequest;

import java.util.Collection;
import java.util.Collections;
Expand All @@ -34,9 +35,6 @@
*/
public class NewTopic {

private static final int NO_PARTITIONS = -1;
private static final short NO_REPLICATION_FACTOR = -1;

private final String name;
private final Optional<Integer> numPartitions;
private final Optional<Short> replicationFactor;
Expand Down Expand Up @@ -87,14 +85,14 @@ public String name() {
* The number of partitions for the new topic or -1 if a replica assignment has been specified.
*/
public int numPartitions() {
return numPartitions.orElse(NO_PARTITIONS);
return numPartitions.orElse(CreateTopicsRequest.NO_NUM_PARTITIONS);
}

/**
* The replication factor for the new topic or -1 if a replica assignment has been specified.
*/
public short replicationFactor() {
return replicationFactor.orElse(NO_REPLICATION_FACTOR);
return replicationFactor.orElse(CreateTopicsRequest.NO_REPLICATION_FACTOR);
}

/**
Expand Down Expand Up @@ -126,8 +124,8 @@ public Map<String, String> configs() {
CreatableTopic convertToCreatableTopic() {
CreatableTopic creatableTopic = new CreatableTopic().
setName(name).
setNumPartitions(numPartitions.orElse(NO_PARTITIONS)).
setReplicationFactor(replicationFactor.orElse(NO_REPLICATION_FACTOR));
setNumPartitions(numPartitions.orElse(CreateTopicsRequest.NO_NUM_PARTITIONS)).
setReplicationFactor(replicationFactor.orElse(CreateTopicsRequest.NO_REPLICATION_FACTOR));
if (replicasAssignments != null) {
for (Entry<Integer, List<Integer>> entry : replicasAssignments.entrySet()) {
creatableTopic.assignments().add(
Expand Down