Skip to content

KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries #9069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vitojeng wants to merge 1 commit into from
Closed

KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries #9069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import org.apache.kafka.streams.errors.ProcessorStateException;
import org.apache.kafka.streams.errors.StreamsException;
import org.apache.kafka.streams.errors.TopologyException;
import org.apache.kafka.streams.errors.UnknownStateStoreException;
import org.apache.kafka.streams.internals.ApiUtils;
import org.apache.kafka.streams.internals.metrics.ClientMetrics;
import org.apache.kafka.streams.kstream.KStream;
Expand Down Expand Up @@ -155,6 +156,7 @@ public class KafkaStreams implements AutoCloseable {
private final QueryableStoreProvider queryableStoreProvider;
private final Admin adminClient;
private final StreamsMetricsImpl streamsMetrics;
private final Set<String> stateStoreNames;

GlobalStreamThread globalStreamThread;
private KafkaStreams.StateListener stateListener;
Expand Down Expand Up @@ -805,6 +807,8 @@ private KafkaStreams(final InternalTopologyBuilder internalTopologyBuilder,

maybeWarnAboutCodeInRocksDBConfigSetter(log, config);
rocksDBMetricsRecordingService = maybeCreateRocksDBMetricsRecordingService(clientId, config);

stateStoreNames = internalTopologyBuilder.allStateStoreName();
}

private ScheduledExecutorService setupStateDirCleaner() {
Expand Down Expand Up @@ -1202,9 +1206,13 @@ public <T> T store(final String storeName, final QueryableStoreType<T> queryable
* @return A facade wrapping the local {@link StateStore} instances
* @throws InvalidStateStoreException if Kafka Streams is (re-)initializing or a store with {@code storeName} and
* {@code queryableStoreType} doesn't exist
* @throws UnknownStateStoreException if given state store name is unknown.
*/
public <T> T store(final StoreQueryParameters<T> storeQueryParameters) {
validateIsRunningOrRebalancing();
if (!stateStoreNames.contains(storeQueryParameters.storeName())) {
throw new UnknownStateStoreException("Unknown state store: " + storeQueryParameters.storeName());
}
return queryableStoreProvider.getStore(storeQueryParameters);
}

Expand Down
16 changes: 14 additions & 2 deletions streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.apache.kafka.common.utils.MockTime;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.streams.errors.TopologyException;
import org.apache.kafka.streams.errors.UnknownStateStoreException;
import org.apache.kafka.streams.internals.metrics.ClientMetrics;
import org.apache.kafka.streams.kstream.Materialized;
import org.apache.kafka.streams.processor.AbstractProcessor;
Expand All @@ -48,6 +49,7 @@
import org.apache.kafka.streams.processor.internals.metrics.StreamsMetricsImpl;
import org.apache.kafka.streams.processor.internals.testutil.LogCaptureAppender;
import org.apache.kafka.streams.state.KeyValueStore;
import org.apache.kafka.streams.state.QueryableStoreTypes;
import org.apache.kafka.streams.state.RocksDBConfigSetter;
import org.apache.kafka.streams.state.StoreBuilder;
import org.apache.kafka.streams.state.Stores;
Expand Down Expand Up @@ -115,7 +117,7 @@ public class KafkaStreamsTest {
private MockTime time;

private Properties props;

@Mock
private StateDirectory stateDirectory;
@Mock
Expand Down Expand Up @@ -693,6 +695,16 @@ public void shouldNotGetQueryMetadataWithPartitionerWhenNotRunningOrRebalancing(
streams.queryMetadataForKey("store", "key", (topic, key, value, numPartitions) -> 0);
}

@Test(expected = UnknownStateStoreException.class)

@vitojeng vitojeng Jul 24, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if using annotation is a good choice. Would it be better to use assertThrows ?

public void shouldThrowUnknownStateStoreExceptionWhenStoreNotExist() throws Exception {
final KafkaStreams streams = new KafkaStreams(new StreamsBuilder().build(), props, supplier, time);
streams.start();
TestUtils.waitForCondition(
() -> streams.state().isRunningOrRebalancing(),
"Streams never started.");
streams.store(StoreQueryParameters.fromNameAndType("unknown-store", QueryableStoreTypes.keyValueStore()));
}

@Test
public void shouldReturnEmptyLocalStorePartitionLags() {
// Mock all calls made to compute the offset lags,
Expand Down Expand Up @@ -977,7 +989,7 @@ public void process(final String key, final String value) {
new MockProcessorSupplier<>());
return topology;
}

private StreamsBuilder getBuilderWithSource() {
final StreamsBuilder builder = new StreamsBuilder();
builder.stream("source-topic");
Expand Down
4 changes: 2 additions & 2 deletions ...s/src/test/java/org/apache/kafka/streams/integration/StreamStreamJoinIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import org.apache.kafka.streams.StoreQueryParameters;
import org.apache.kafka.streams.StreamsBuilder;
import org.apache.kafka.streams.StreamsConfig;
import org.apache.kafka.streams.errors.InvalidStateStoreException;
import org.apache.kafka.streams.errors.UnknownStateStoreException;
import org.apache.kafka.streams.kstream.Consumed;
import org.apache.kafka.streams.kstream.JoinWindows;
import org.apache.kafka.streams.kstream.KStream;
Expand Down Expand Up @@ -94,7 +94,7 @@ public void shouldNotAccessJoinStoresWhenGivingName() throws InterruptedExceptio

kafkaStreams.start();
latch.await();
assertThrows(InvalidStateStoreException.class, () -> kafkaStreams.store(StoreQueryParameters.fromNameAndType("join-store", QueryableStoreTypes.keyValueStore())));
assertThrows(UnknownStateStoreException.class, () -> kafkaStreams.store(StoreQueryParameters.fromNameAndType("join-store", QueryableStoreTypes.keyValueStore())));
}
}

Expand Down