Skip to content

KAFKA-10246 : AbstractProcessorContext topic() throws NPE #9034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbccdda merged 2 commits into from
Jul 25, 2020
Merged

KAFKA-10246 : AbstractProcessorContext topic() throws NPE #9034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da0aa30
KAFKA-10246 : Issue Fix - AbstractProcessorContext topic() throws Nul…
Jul 17, 2020
e5ca682
KAFKA-10246 : Added unit test case to validate NPE issue resolve
Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public String topic() {

final String topic = recordContext.topic();

if (topic.equals(NONEXIST_TOPIC)) {
if (NONEXIST_TOPIC.equals(topic)) {
return null;
}

Expand Down
6 changes: 6 additions & 0 deletions .../test/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ public void shouldThrowIllegalStateExceptionOnTopicIfNoRecordContext() {
}
}

@Test
public void shouldNotThrowNullPointerExceptionOnTopicIfRecordContextTopicIsNull() {
context.setRecordContext(new ProcessorRecordContext(0, 0, 0, null, null));
assertThat(context.topic(), nullValue());
}

@Test
public void shouldReturnTopicFromRecordContext() {
assertThat(context.topic(), equalTo(recordContext.topic()));
Expand Down