KAFKA-9629 Use generated protocol for Fetch API #9008
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.kafka.common.protocol; | ||
|
|
||
| import org.apache.kafka.common.record.BaseRecords; | ||
| import org.apache.kafka.common.record.MemoryRecords; | ||
| import org.apache.kafka.common.utils.ByteUtils; | ||
|
|
||
| import java.nio.ByteBuffer; | ||
|
|
||
| /** | ||
| * Implementation of Readable which reads from a byte buffer and can read records as {@link MemoryRecords} | ||
| * | ||
| * @see org.apache.kafka.common.requests.FetchResponse | ||
| */ | ||
| public class RecordsReader implements Readable { | ||
|
hachikuji marked this conversation as resolved.
Outdated
|
||
| private final ByteBuffer buf; | ||
|
|
||
| public RecordsReader(ByteBuffer buf) { | ||
| this.buf = buf; | ||
| } | ||
|
|
||
| @Override | ||
| public byte readByte() { | ||
| return buf.get(); | ||
| } | ||
|
|
||
| @Override | ||
| public short readShort() { | ||
| return buf.getShort(); | ||
| } | ||
|
|
||
| @Override | ||
| public int readInt() { | ||
| return buf.getInt(); | ||
| } | ||
|
|
||
| @Override | ||
| public long readLong() { | ||
| return buf.getLong(); | ||
| } | ||
|
|
||
| @Override | ||
| public double readDouble() { | ||
| return ByteUtils.readDouble(buf); | ||
| } | ||
|
|
||
| @Override | ||
| public void readArray(byte[] arr) { | ||
| buf.get(arr); | ||
| } | ||
|
|
||
| @Override | ||
| public int readUnsignedVarint() { | ||
| return ByteUtils.readUnsignedVarint(buf); | ||
| } | ||
|
|
||
| @Override | ||
| public ByteBuffer readByteBuffer(int length) { | ||
|
Contributor
There was a problem hiding this comment. More of a side question, but is this length guaranteed to be less than the buffer size? Wondering if it is worth adding range checking.
Member
Author
There was a problem hiding this comment. This is copied straight from ByteBufferAccessor and will probably go away in a follow-on PR. But either way, looking at it it seems it should always be in range since this is used by zero-copy byte fields in the message classes, e.g. int len = _reader.readInt();
if (len > 0) {
this.someZeroCopyField = _reader.readByteBuffer(len);
}So generally it's probably safe. In the case of a corrupt message where the length is wrong, ByteBuffer#limit will throw an error and parsing will fail. It probably would be nice to put a range check in ByteBufferAccessor so we can throw a more useful error. |
||
| ByteBuffer res = buf.slice(); | ||
| res.limit(length); | ||
|
|
||
| buf.position(buf.position() + length); | ||
|
|
||
| return res; | ||
| } | ||
|
|
||
| public BaseRecords readRecords(int length) { | ||
| if (length < 0) { | ||
| // no records | ||
| return null; | ||
| } else { | ||
| ByteBuffer recordsBuffer = readByteBuffer(length); | ||
| return MemoryRecords.readableRecords(recordsBuffer); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could probably change this to use
ifPresent