KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once - #8973
Merged
Conversation
Contributor
|
ok to test |
Contributor
Author
|
@gharris1727 @chia7712 @ncliang would any of you be interested in reviewing this? |
Contributor
|
retest this please |
rhauch
approved these changes
Sep 28, 2020
rhauch
pushed a commit
that referenced
this pull request
Sep 28, 2020
…tchup fails once (#8973) Add logic to reset the existing `canReadConfigs` in `DistributedHerder` once the herder is able to successfully read the configs again. Added unit test to verify the functionality. Author: Chris Egerton <chrise@confluent.io> Reviewer: Nigel Liang <nigel@nigelliang.com>, Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Sep 28, 2020
…tchup fails once (#8973) Add logic to reset the existing `canReadConfigs` in `DistributedHerder` once the herder is able to successfully read the configs again. Added unit test to verify the functionality. Author: Chris Egerton <chrise@confluent.io> Reviewer: Nigel Liang <nigel@nigelliang.com>, Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Sep 29, 2020
…tchup fails once (#8973) Add logic to reset the existing `canReadConfigs` in `DistributedHerder` once the herder is able to successfully read the configs again. Added unit test to verify the functionality. Author: Chris Egerton <chrise@confluent.io> Reviewer: Nigel Liang <nigel@nigelliang.com>, Randall Hauch <rhauch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
We added a
canReadConfigsfield to theDistributedHerdera while back that gets set tofalseif the herder fails to catch up to the end of the config topic, but never gets set totrueagain if catchup succeeds at a later point.This PR adds logic to reset it to
truewhen it's safe to.A single unit test is tweaked to ensure that the herder doesn't keep unnecessarily trying to catch up to the end of the config topic during every tick.
Committer Checklist (excluded from commit message)