Skip to content

KAFKA-10185: Restoration info logging (#8896) #8904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvcephei merged 1 commit into from
Jun 21, 2020
Merged

KAFKA-10185: Restoration info logging (#8896) #8904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import java.util.Set;

public class StoreChangelogReader implements ChangelogReader {
private static final long RESTORE_LOG_INTERVAL_MS = 10_000L;

private final Logger log;
private final Consumer<byte[], byte[]> restoreConsumer;
Expand All @@ -53,6 +54,8 @@ public class StoreChangelogReader implements ChangelogReader {
private final Set<TopicPartition> completedRestorers = new HashSet<>();
private final Duration pollTime;

private long lastRestoreLogTime = 0L;

public StoreChangelogReader(final Consumer<byte[], byte[]> restoreConsumer,
final Duration pollTime,
final StateRestoreListener userStateRestoreListener,
Expand Down Expand Up @@ -120,9 +123,42 @@ public Collection<TopicPartition> restore(final RestoringTasks active) {

checkForCompletedRestoration();

maybeLogRestorationProgress();

return completedRestorers;
}

private void maybeLogRestorationProgress() {
if (needsRestoring.isEmpty()) {
lastRestoreLogTime = 0L;
} else {
final long now = System.currentTimeMillis();
if (now - lastRestoreLogTime > RESTORE_LOG_INTERVAL_MS) {
final Set<TopicPartition> topicPartitions = needsRestoring;
if (!topicPartitions.isEmpty()) {
final StringBuilder builder = new StringBuilder().append("Restoration in progress for ")
.append(topicPartitions.size())
.append(" partitions.");
for (final TopicPartition partition : topicPartitions) {
final StateRestorer stateRestorer = stateRestorers.get(partition);
builder.append(" {")
.append(partition)
.append(": ")
.append("position=")
.append(stateRestorer.restoredOffset())
.append(", end=")
.append(restoreToOffsets.get(partition))
.append(", totalRestored=")
.append(stateRestorer.restoredNumRecords())
.append("}");
}
log.info(builder.toString());
lastRestoreLogTime = now;
}
}
}
}

private void initialize(final RestoringTasks active) {
if (!restoreConsumer.subscription().isEmpty()) {
throw new StreamsException("Restore consumer should not be subscribed to any topics (" + restoreConsumer.subscription() + ")");
Expand Down