Skip to content

HOTFIX: Fix compile error in TopicAdminTest#8866

Merged
kkonstantine merged 1 commit into
apache:trunkfrom
chia7712:HOTFIX-TopicAdminTest
Jun 13, 2020
Merged

HOTFIX: Fix compile error in TopicAdminTest#8866
kkonstantine merged 1 commit into
apache:trunkfrom
chia7712:HOTFIX-TopicAdminTest

Conversation

@chia7712

@chia7712 chia7712 commented Jun 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

9a4f00f changed the constructor of DescribeConfigsResponse.

/home/chia7712/kafka/connect/runtime/src/test/java/org/apache/kafka/connect/util/TopicAdminTest.java:582: error: incompatible types: int cannot be converted to Struct
        return new DescribeConfigsResponse(1000, configs);
                                           ^
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
1 error

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712

chia7712 commented Jun 13, 2020

Copy link
Copy Markdown
Member Author

@tombentley Could you take a look?

abbccdda
abbccdda reviewed Jun 13, 2020
View reviewed changes

@abbccdda abbccdda left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 Could you include the actual failure in the summary?

kkonstantine
kkonstantine reviewed Jun 13, 2020
View reviewed changes

@kkonstantine kkonstantine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @chia7712
I left a couple of comments.

Comment thread connect/runtime/src/test/java/org/apache/kafka/connect/util/TopicAdminTest.java Outdated
Comment thread connect/runtime/src/test/java/org/apache/kafka/connect/util/TopicAdminTest.java Outdated
@ableegoldman ableegoldman mentioned this pull request Jun 13, 2020
Merged
@chia7712
chia7712 force-pushed the HOTFIX-TopicAdminTest branch from d6fe7b4 to be960b8 Compare June 13, 2020 05:37
@chia7712

chia7712 commented Jun 13, 2020

Copy link
Copy Markdown
Member Author

@abbccdda I attache the error message to the description.

@kkonstantine I have addressed your comment

Please take a look :)

kkonstantine
kkonstantine approved these changes Jun 13, 2020
View reviewed changes

@kkonstantine kkonstantine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chia7712
LGTM

Waiting for a green build

@tombentley

tombentley commented Jun 13, 2020

Copy link
Copy Markdown
Member

Sorry about breaking the build. Thanks @chia7712.

tombentley
tombentley approved these changes Jun 13, 2020
View reviewed changes

@tombentley tombentley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkonstantine kkonstantine changed the title HOTFIX: fix compile error in o.a.k.c.u.TopicAdminTest HOTFIX: Fix compile error in TopicAdminTest Jun 13, 2020
@kkonstantine

kkonstantine commented Jun 13, 2020

Copy link
Copy Markdown
Contributor

The few test failures were not relevant. Merging to fix the build anyways.

@kkonstantine
kkonstantine merged commit 88fe466 into apache:trunk Jun 13, 2020
Kvicii pushed a commit to Kvicii/kafka that referenced this pull request Jun 13, 2020
Merge branch 'trunk' of github.com:apache/kafka into trunk-read
49b7b7f 
* 'trunk' of github.com:apache/kafka: (42 commits)
  HOTFIX: Fix compile error in TopicAdminTest (apache#8866)
  KAFKA-10144: clean up corrupted standby tasks before attempting a commit (apache#8849)
  KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener (apache#8857)
  KAFKA-9432: automated protocol for DescribeConfigs (apache#8312)
  KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes (apache#8764)
  KAFKA-10027: Implement read path for feature versioning system (KIP-584) (apache#8680)
  KAFKA-10085: correctly compute lag for optimized source changelogs (apache#8787)
  KAFKA-10086: Integration test for ensuring warmups are effective (apache#8818)
  KAFKA-9374: Make connector interactions asynchronous (apache#8069)
  MINOR: reduce sizeInBytes for percentiles metrics (apache#8835)
  KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter (apache#8829)
  KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy (apache#8828)
  KAFKA-9845: Warn users about using config providers with plugin.path property (apache#8455)
  KAFKA-7833: Add missing test (apache#8847)
  KAFKA-9066: Retain metrics for failed tasks (apache#8502)
  KAFKA-9841: Revoke duplicate connectors and tasks when zombie workers return with an outdated assignment (apache#8453)
  KAFKA-9985: Sink connector may exhaust broker when writing in DLQ (apache#8663)
  KAFKA-9441: remove prepareClose() to simplify task management (apache#8833)
  KAFKA-7833: Add Global/StateStore name conflict check (apache#8825)
  KAFKA-9969: Exclude ConnectorClientConfigRequest from class loading isolation (apache#8630)
  ...
stevenpyzhang added a commit to confluentinc/kafka that referenced this pull request Jul 18, 2020
@stevenpyzhang
Revert "HOTFIX: Fix compile error in TopicAdminTest (apache#8866)"
b92cda7 
This reverts commit 88fe466.
@chia7712
chia7712 deleted the HOTFIX-TopicAdminTest branch March 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbccdda abbccdda abbccdda left review comments
@tombentley tombentley tombentley approved these changes
@kkonstantine kkonstantine kkonstantine approved these changes

Assignees

No one assigned

Labels

connect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chia7712 @tombentley @kkonstantine @abbccdda