MINOR: Print all removed dynamic members during join complete#8816
Merged
Conversation
abbccdda
commented
Jun 5, 2020
dajac
reviewed
Jun 5, 2020
hachikuji
reviewed
Jun 5, 2020
| for (member <- group.allMemberMetadata) { | ||
| val joinResult = JoinGroupResult( | ||
| members = if (group.isLeader(member.memberId)) { | ||
| info(s"Group ${group.groupId} replies the leader with " + |
Contributor
There was a problem hiding this comment.
Do we need to print this for every member? That is O(n^2). Keep in mind that groups in the thousands are not unheard of. I think it would be better if we just ensured that we log the id of every member entering and leaving the group.
abbccdda
force-pushed
the
minor_group_coordinator
branch
from
June 6, 2020 00:32
901f50e to
fcfb77f
Compare
abbccdda
changed the title
Contributor
|
okay to test |
Contributor
|
okay to test |
1 similar comment
Contributor
|
okay to test |
Contributor
|
Test this please |
1 similar comment
Contributor
|
Test this please |
Contributor
|
Retest this please |
guozhangwang
approved these changes
Jun 10, 2020
guozhangwang
left a comment
guozhangwang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the improved test assertion coverage too! Merging to trunk.
| group.notYetRejoinedMembers.filterNot(_.isStaticMember) foreach { failedMember => | ||
| removeHeartbeatForLeavingMember(group, failedMember) | ||
| group.remove(failedMember.memberId) | ||
| group.removeStaticMember(failedMember.groupInstanceId) |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Nov 17, 2020
…t-for-generated-requests * apache-github/trunk: (248 commits) KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes (apache#8764) KAFKA-10027: Implement read path for feature versioning system (KIP-584) (apache#8680) KAFKA-10085: correctly compute lag for optimized source changelogs (apache#8787) KAFKA-10086: Integration test for ensuring warmups are effective (apache#8818) KAFKA-9374: Make connector interactions asynchronous (apache#8069) MINOR: reduce sizeInBytes for percentiles metrics (apache#8835) KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter (apache#8829) KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy (apache#8828) KAFKA-9845: Warn users about using config providers with plugin.path property (apache#8455) KAFKA-7833: Add missing test (apache#8847) KAFKA-9066: Retain metrics for failed tasks (apache#8502) KAFKA-9841: Revoke duplicate connectors and tasks when zombie workers return with an outdated assignment (apache#8453) KAFKA-9985: Sink connector may exhaust broker when writing in DLQ (apache#8663) KAFKA-9441: remove prepareClose() to simplify task management (apache#8833) KAFKA-7833: Add Global/StateStore name conflict check (apache#8825) KAFKA-9969: Exclude ConnectorClientConfigRequest from class loading isolation (apache#8630) KAFKA-9991: Fix flaky unit tests (apache#8843) KAFKA-10014; Always try to close all channels in Selector#close (apache#8685) KAFKA-10079: improve thread-level stickiness (apache#8775) MINOR: Print all removed dynamic members during join complete (apache#8816) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better visibility on the group rebalance, we are trying to print out the evicted members inside the group coordinator during rebalance complete.
Committer Checklist (excluded from commit message)