Skip to content

KAFKA-9514; The protocol generator generated useless condition when a field is made nullable and flexible version is used #8793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmccabe merged 1 commit into from
Jun 4, 2020
Merged

KAFKA-9514; The protocol generator generated useless condition when a field is made nullable and flexible version is used #8793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,8 +1436,8 @@ private void generateVariableLengthWriter(Versions fieldFlexibleVersions,
alwaysEmitBlockScope(type.isString()).
ifNull(() -> {
VersionConditional.forVersions(nullableVersions, possibleVersions).
ifMember(__ -> {
VersionConditional.forVersions(fieldFlexibleVersions, possibleVersions).
ifMember(presentVersions -> {
VersionConditional.forVersions(fieldFlexibleVersions, presentVersions).
ifMember(___ -> {
buffer.printf("_writable.writeUnsignedVarint(0);%n");
}).
Expand Down
6 changes: 0 additions & 6 deletions gradle/spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,6 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read
<Bug pattern="MS_MUTABLE_ARRAY"/>
</Match>

<Match>
<!-- The code generator generates useless condition. Disable the check temporarily. -->
<Class name="org.apache.kafka.common.message.JoinGroupResponseData"/>
<Bug pattern="UC_USELESS_CONDITION"/>
</Match>

<Match>
<!-- Suppress warnings about ignoring the return value of await.
This is done intentionally because we use other clues to determine
Expand Down