Skip to content

KAFKA-9788: Use distinct names for transaction and group load time se… #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 2 commits into from
Jun 4, 2020
Merged

KAFKA-9788: Use distinct names for transaction and group load time se… #8784

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82ada93
KAFKA-9788: Use distinct names for transaction and group load time se…
bob-barrett Jun 2, 2020
68127ae
Add group metrics constants
bob-barrett Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ import org.apache.kafka.common.requests.{OffsetCommitRequest, OffsetFetchRespons
import org.apache.kafka.common.utils.{Time, Utils}
import org.apache.kafka.common.{KafkaException, TopicPartition}

import scala.jdk.CollectionConverters._
import scala.collection._
import scala.collection.mutable.ArrayBuffer
import scala.jdk.CollectionConverters._

class GroupMetadataManager(brokerId: Int,
interBrokerProtocolVersion: ApiVersion,
Expand Down Expand Up @@ -89,7 +89,7 @@ class GroupMetadataManager(brokerId: Int,
private val openGroupsForProducer = mutable.HashMap[Long, mutable.Set[String]]()

/* setup metrics*/
val partitionLoadSensor = metrics.sensor("PartitionLoadTime")
private val partitionLoadSensor = metrics.sensor("GroupPartitionLoadTime")

@hachikuji hachikuji Jun 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we may as well add constant names for this as well as the metric group?


partitionLoadSensor.add(metrics.metricName("partition-load-time-max",
"group-coordinator-metrics",
Expand Down
9 changes: 6 additions & 3 deletions core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ object TransactionStateManager {
val DefaultTransactionalIdExpirationMs: Int = TimeUnit.DAYS.toMillis(7).toInt
val DefaultAbortTimedOutTransactionsIntervalMs: Int = TimeUnit.SECONDS.toMillis(10).toInt
val DefaultRemoveExpiredTransactionalIdsIntervalMs: Int = TimeUnit.HOURS.toMillis(1).toInt

val MetricsGroup: String = "transaction-coordinator-metrics"
val LoadTimeSensor: String = "TransactionsPartitionLoadTime"
}

/**
Expand Down Expand Up @@ -95,13 +98,13 @@ class TransactionStateManager(brokerId: Int,
private val transactionTopicPartitionCount = getTransactionTopicPartitionCount

/** setup metrics*/
private val partitionLoadSensor = metrics.sensor("PartitionLoadTime")
private val partitionLoadSensor = metrics.sensor(TransactionStateManager.LoadTimeSensor)

partitionLoadSensor.add(metrics.metricName("partition-load-time-max",
"transaction-coordinator-metrics",
TransactionStateManager.MetricsGroup,
"The max time it took to load the partitions in the last 30sec"), new Max())
partitionLoadSensor.add(metrics.metricName("partition-load-time-avg",
"transaction-coordinator-metrics",
TransactionStateManager.MetricsGroup,
"The avg time it took to load the partitions in the last 30sec"), new Avg())

// visible for testing only
Expand Down