Skip to content

KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends #8782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 3 commits into from
Jun 3, 2020
Merged

KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends #8782

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44d2815
KAFKA-10080; Fix race condition on txn completion which can cause dup…
hachikuji Jun 2, 2020
9d1d560
Rename pendingCommitTxn to pendingCompleteTxn
hachikuji Jun 2, 2020
c52dc75
Fix failing test due to nice mock change
hachikuji Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...c/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ class TransactionMarkerChannelManagerTest {
EasyMock.replay(metadataCache)

channelManager.addTxnMarkersToSend(coordinatorEpoch, txnResult, txnMetadata1, txnMetadata1.prepareComplete(time.milliseconds()))
channelManager.addTxnMarkersToSend(coordinatorEpoch, txnResult, txnMetadata2, txnMetadata2.prepareComplete(time.milliseconds()))

@hachikuji hachikuji Jun 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to use mock instead of niceMock led to a failure because of an unexpected append to the log. It seemed like this call was not necessary to test the behavior we were interested in here, so I removed it rather than adding the expected call to append.


assertEquals(1, channelManager.numTxnsWithPendingMarkers)
assertEquals(1, channelManager.queueForBroker(broker2.id).get.totalNumMarkers)
Expand Down