Skip to content

KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests #8778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
showuon wants to merge 1 commit into from
Closed

KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests #8778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...nts/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public abstract class AbstractStickyAssignor extends AbstractPartitionAssignor {

public static final int DEFAULT_GENERATION = -1;

private PartitionMovements partitionMovements = new PartitionMovements();
private PartitionMovements partitionMovements;

@ableegoldman ableegoldman Jun 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we still initialize it here as well? I remember that was necessary for some tests to pass since they might never get to the generalAssign method and isSticky would hit NPE

On the other hand, it seems like isSticky is pointless to call unless we get to the generalAssign method. So maybe we should just remove that from the tests that only do the constrainedAssign and just verify the stickiness directly?


// Keep track of the partitions being migrated from one consumer to another during assignment
// so the cooperative assignor can adjust the assignment
Expand Down Expand Up @@ -272,6 +272,7 @@ private Map<String, List<TopicPartition>> generalAssign(Map<String, Integer> par
Map<String, Subscription> subscriptions) {
Map<String, List<TopicPartition>> currentAssignment = new HashMap<>();
Map<TopicPartition, ConsumerGenerationPair> prevAssignment = new HashMap<>();
partitionMovements = new PartitionMovements();

prepopulateCurrentAssignments(subscriptions, currentAssignment, prevAssignment);
boolean isFreshAssignment = currentAssignment.isEmpty();
Expand Down