Skip to content

MINOR: Add explanation for disabling forwarding from value transformers #8771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 6 commits into from
Jun 4, 2020
Merged

MINOR: Add explanation for disabling forwarding from value transformers #8771

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c60aa60
Add explanation for disabling message forwarding from key/value trans…
astubbs May 26, 2020
6bc180e
Static final
astubbs Jun 2, 2020
1a69175
English fix
astubbs Jun 2, 2020
dea83c2
I can’t English
astubbs Jun 2, 2020
eea1d3a
More English
astubbs Jun 2, 2020
02b0605
Caps
astubbs Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...java/org/apache/kafka/streams/processor/internals/ForwardingDisabledProcessorContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
public final class ForwardingDisabledProcessorContext implements ProcessorContext {
private final ProcessorContext delegate;

private String explanation = "ProcessorContext#forward() is not supported from this context, "
Comment thread
astubbs marked this conversation as resolved.
Outdated
+ "as the framework must ensure the key is not changed (#forward allows changing the key on "
+ "messages which are sent). Try plain other functions which don't allow the key to be changed.";

public ForwardingDisabledProcessorContext(final ProcessorContext delegate) {
this.delegate = Objects.requireNonNull(delegate, "delegate");
}
Expand Down Expand Up @@ -102,24 +106,24 @@ public Cancellable schedule(final Duration interval,

@Override
public <K, V> void forward(final K key, final V value) {
throw new StreamsException("ProcessorContext#forward() not supported.");
throw new StreamsException(explanation);
}

@Override
public <K, V> void forward(final K key, final V value, final To to) {
throw new StreamsException("ProcessorContext#forward() not supported.");
throw new StreamsException(explanation);
}

@Override
@Deprecated
public <K, V> void forward(final K key, final V value, final int childIndex) {
throw new StreamsException("ProcessorContext#forward() not supported.");
throw new StreamsException(explanation);
}

@Override
@Deprecated
public <K, V> void forward(final K key, final V value, final String childName) {
throw new StreamsException("ProcessorContext#forward() not supported.");
throw new StreamsException(explanation);
}

@Override
Expand Down