KAFKA-10060 GroupMetadataManager should not log if there are no offse…#8767
Merged
Conversation
chia7712
commented
May 31, 2020
Member
Author
There was a problem hiding this comment.
create another GroupMetadataManager to override the methods we want to verify
ijuma
reviewed
May 31, 2020
ijuma
left a comment
ijuma
left a comment
Member
There was a problem hiding this comment.
Changes look good generally, just a couple of nits.
Member
There was a problem hiding this comment.
Nit: we don't use private[this] for tests. It's mostly a micro-optimization is not particularly useful for tests (private provides good enough semantics).
Member
|
Unrelated flaky test failure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address @ijuma comment
Committer Checklist (excluded from commit message)