Skip to content

MINOR: Replace null with an actual value for timestamp field in InsertField SMT unit tests #8649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkonstantine merged 2 commits into from
May 12, 2020
Merged

MINOR: Replace null with an actual value for timestamp field in InsertField SMT unit tests #8649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3fdc3a
MINOR: Add a unit test for timestamp field in InsertField SMT
wicknicks May 12, 2020
307a5f4
MINOR: Update existing tests instead of making new ones
wicknicks May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions connect/transforms/src/test/java/org/apache/kafka/connect/transforms/InsertFieldTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.junit.Test;

import java.util.Collections;
import java.util.Date;
import java.util.HashMap;
import java.util.Map;

Expand Down Expand Up @@ -61,7 +62,7 @@ public void copySchemaAndInsertConfiguredFields() {
final Schema simpleStructSchema = SchemaBuilder.struct().name("name").version(1).doc("doc").field("magic", Schema.OPTIONAL_INT64_SCHEMA).build();
final Struct simpleStruct = new Struct(simpleStructSchema).put("magic", 42L);

final SourceRecord record = new SourceRecord(null, null, "test", 0, simpleStructSchema, simpleStruct);
final SourceRecord record = new SourceRecord(null, null, "test", 0, null, null, simpleStructSchema, simpleStruct, 789L);
final SourceRecord transformedRecord = xformValue.apply(record);

assertEquals(simpleStructSchema.name(), transformedRecord.valueSchema().name());
Expand All @@ -78,7 +79,7 @@ public void copySchemaAndInsertConfiguredFields() {
assertEquals(0, ((Struct) transformedRecord.value()).getInt32("partition_field").intValue());

assertEquals(Timestamp.builder().optional().build(), transformedRecord.valueSchema().field("timestamp_field").schema());
assertEquals(null, ((Struct) transformedRecord.value()).getInt64("timestamp_field"));
assertEquals(789L, ((Date) ((Struct) transformedRecord.value()).get("timestamp_field")).getTime());

assertEquals(Schema.OPTIONAL_STRING_SCHEMA, transformedRecord.valueSchema().field("instance_id").schema());
assertEquals("my-instance-id", ((Struct) transformedRecord.value()).getString("instance_id"));
Expand All @@ -101,18 +102,17 @@ public void schemalessInsertConfiguredFields() {
xformValue.configure(props);

final SourceRecord record = new SourceRecord(null, null, "test", 0,
null, Collections.singletonMap("magic", 42L));
null, null, null, Collections.singletonMap("magic", 42L), 123L);

final SourceRecord transformedRecord = xformValue.apply(record);

assertEquals(42L, ((Map<?, ?>) transformedRecord.value()).get("magic"));
assertEquals("test", ((Map<?, ?>) transformedRecord.value()).get("topic_field"));
assertEquals(0, ((Map<?, ?>) transformedRecord.value()).get("partition_field"));
assertEquals(null, ((Map<?, ?>) transformedRecord.value()).get("timestamp_field"));
assertEquals(123L, ((Map<?, ?>) transformedRecord.value()).get("timestamp_field"));
assertEquals("my-instance-id", ((Map<?, ?>) transformedRecord.value()).get("instance_id"));
}


@Test
public void insertConfiguredFieldsIntoTombstoneEventWithoutSchemaLeavesValueUnchanged() {
final Map<String, Object> props = new HashMap<>();
Expand Down