Skip to content

HOTFIX: Fix broker bounce system tests #8532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 1 commit into from
Apr 24, 2020
Merged

HOTFIX: Fix broker bounce system tests #8532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/kafkatest/tests/streams/streams_broker_bounce_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3):

# Start test harness
self.driver = StreamsSmokeTestDriverService(self.test_context, self.kafka)
self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, num_threads)
self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, "at_least_once", num_threads)

@cadonna cadonna Apr 22, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it enough to specify the processing guarantee as at_least_once here or do you want also for this test to include all processing guarantees in the test matrix?

@cadonna cadonna Apr 22, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a different note, now that the processing guarantee can be passed to the service, do we still need StreamsEosTestJobRunnerService and StreamsComplexEosTestJobRunnerService?

@abbccdda abbccdda Apr 24, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel neutral about it, if we are adding 2X time to system tests, that's probably not good.

@mjsax mjsax Apr 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try to add both eos cases, too.

For Streams[Complex]EosTestJobRunnerService, they use a different Java class compared to the "smoke test" runner. Not sure if we could unify them?


self.driver.start()

Expand Down
2 changes: 1 addition & 1 deletion tests/kafkatest/tests/streams/streams_upgrade_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def test_upgrade_downgrade_brokers(self, from_version, to_version):

self.driver = StreamsSmokeTestDriverService(self.test_context, self.kafka)

processor = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka)
processor = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, "at_least_once")

with self.driver.node.account.monitor_log(self.driver.STDOUT_FILE) as driver_monitor:
self.driver.start()
Expand Down