MINOR: add support for kafka 2.4 and 2.5 to downgrade test#8518
Closed
lbradstreet wants to merge 2 commits into
Closed
MINOR: add support for kafka 2.4 and 2.5 to downgrade test#8518lbradstreet wants to merge 2 commits into
lbradstreet wants to merge 2 commits into
Conversation
Member
|
ok to test |
Contributor
Author
|
Result after running in ducker: |
abbccdda
reviewed
Apr 20, 2020
| version=kafka_version) | ||
| self.producer.start() | ||
|
|
||
| static_membership = kafka_version == DEV_BRANCH or kafka_version >= LATEST_2_3 |
There was a problem hiding this comment.
Why does static membership make a difference here?
Contributor
Author
There was a problem hiding this comment.
Good question, without it the verifiable consumer fails with:
usage: verifiable-consumer [-h]
--broker-list HOST1:PORT1[,HOST2:PORT2[...]]
--topic TOPIC --group-id GROUP_ID
--group-instance-id GROUP_INSTANCE_ID
[--max-messages MAX-MESSAGES]
[--session-timeout TIMEOUT_MS] [--verbose]
[--enable-autocommit]
[--reset-policy RESETPOLICY]
[--assignment-strategy ASSIGNMENTSTRATEGY]
[--consumer.config CONFIG_FILE]
verifiable-consumer: error: argument --group-instance-id is required
I assumed that this check was added for a reason, however maybe it's being to strict or buggy?
Contributor
Author
There was a problem hiding this comment.
I believe it's due to 2.4 accidentally requiring --group-instance-id and in this test we end up using this version. See 0f995ba
Contributor
Author
There was a problem hiding this comment.
I could force static throttling to be used when the version is 2.4 or 2.3 and leave a comment if that works for you.
Contributor
Author
There was a problem hiding this comment.
@abbccdda I changed the code to add a static_membership parameter to the test matrix. We simply avoid this for 2.4 where this is broken due to the command line validation in that release.
Contributor
|
ok to test |
Contributor
|
No failures, nice :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downgrade test does not currently support 2.4 and 2.5. When you enable them, it fails as a result of consumer group static membership. This PR makes the downgrade test work with all of our released versions again.