Skip to content

MINOR: Use streaming iterator with decompression buffer when building offset map #8494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijuma merged 1 commit into from
Apr 16, 2020
Merged

MINOR: Use streaming iterator with decompression buffer when building offset map #8494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions core/src/main/scala/kafka/log/LogCleaner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,15 +938,18 @@ private[log] class Cleaner(val id: Int,
// Note that abort markers are supported in v2 and above, which means count is defined.
stats.indexMessagesRead(batch.countOrNull)
} else {
for (record <- batch.asScala) {
if (record.hasKey && record.offset >= startOffset) {
if (map.size < maxDesiredMapSize)
map.put(record.key, record.offset)
else
return true
val recordsIterator = batch.streamingIterator(decompressionBufferSupplier)
try {
for (record <- recordsIterator.asScala) {
if (record.hasKey && record.offset >= startOffset) {
if (map.size < maxDesiredMapSize)
map.put(record.key, record.offset)
else
return true
}
stats.indexMessagesRead(1)
}
stats.indexMessagesRead(1)
}
} finally recordsIterator.close()
}
}

Expand Down