Skip to content

KAFKA-8611 / Refactor KStreamRepartitionIntegrationTest #8470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 3 commits into from
Apr 15, 2020
Merged

KAFKA-8611 / Refactor KStreamRepartitionIntegrationTest #8470

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c481267
KAFKA-8611 / Refactor KStreamRepartitionIntegrationTest
lkokhreidze Apr 12, 2020
084d7e3
KAFKA-8611 / revert build.gradle changes
lkokhreidze Apr 12, 2020
569e9d5
KAFKA-8611 / fix compileTestJava
lkokhreidze Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ...src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameter;
import org.junit.runners.Parameterized.Parameters;

import java.io.IOException;
Expand Down Expand Up @@ -95,24 +96,22 @@ public class KStreamRepartitionIntegrationTest {
private Properties streamsConfiguration;
private List<KafkaStreams> kafkaStreamsInstances;

@Parameters(name = "Optimization = {0}")
public static Collection<Object[]> data() {
final List<Object[]> values = new ArrayList<>();

Arrays.asList(StreamsConfig.OPTIMIZE, StreamsConfig.NO_OPTIMIZATION)
.forEach(x -> values.add(new Object[]{x}));
@Parameter
public String topologyOptimization;

return values;
@Parameters(name = "Optimization = {0}")
public static Collection<?> topologyOptimization() {
return Arrays.asList(new String[][]{
{StreamsConfig.OPTIMIZE},
{StreamsConfig.NO_OPTIMIZATION}
});
}

public KStreamRepartitionIntegrationTest(final String topologyOptimization) {
@Before
public void before() throws InterruptedException {
streamsConfiguration = new Properties();
kafkaStreamsInstances = new ArrayList<>();
streamsConfiguration.put(StreamsConfig.TOPOLOGY_OPTIMIZATION, topologyOptimization);
}

@Before
public void before() throws InterruptedException {
final int testNum = TEST_NUM.incrementAndGet();

topicB = "topic-b-" + testNum;
Expand All @@ -130,6 +129,7 @@ public void before() throws InterruptedException {
streamsConfiguration.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, 100);
streamsConfiguration.put(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, Serdes.Integer().getClass());
streamsConfiguration.put(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, Serdes.String().getClass());
streamsConfiguration.put(StreamsConfig.TOPOLOGY_OPTIMIZATION, topologyOptimization);
}

@After
Expand Down