Skip to content

KAFKA-9852: Change the max duration that calls to the buffer pool can block from 2000ms to 10ms #8464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijuma merged 1 commit into from
Apr 23, 2020
Merged

KAFKA-9852: Change the max duration that calls to the buffer pool can block from 2000ms to 10ms #8464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
public class BufferPoolTest {
private final MockTime time = new MockTime();
private final Metrics metrics = new Metrics(time);
private final long maxBlockTimeMs = 2000;
private final long maxBlockTimeMs = 10;
private final String metricGroup = "TestMetrics";

@After
Expand Down Expand Up @@ -185,7 +185,7 @@ public void testBlockTimeout() throws Exception {
// this is good
}
// Thread scheduling sometimes means that deallocation varies by this point
assertTrue("available memory " + pool.availableMemory(), pool.availableMemory() >= 8 && pool.availableMemory() <= 10);
assertTrue("available memory " + pool.availableMemory(), pool.availableMemory() >= 7 && pool.availableMemory() <= 10);
long durationMs = Time.SYSTEM.milliseconds() - beginTimeMs;
assertTrue("BufferExhaustedException should not throw before maxBlockTimeMs", durationMs >= maxBlockTimeMs);
assertTrue("BufferExhaustedException should throw soon after maxBlockTimeMs", durationMs < maxBlockTimeMs + 1000);
Expand Down