Skip to content

KAFKA-9845: Warn users about using config providers with plugin.path property #8455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhauch merged 7 commits into from
Jun 11, 2020
Merged

KAFKA-9845: Warn users about using config providers with plugin.path property #8455

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
96caaa9
KAFKA-9845: Fix plugin.path when config provider is used
C0urante Apr 9, 2020
ab16154
Revert "KAFKA-9845: Fix plugin.path when config provider is used"
C0urante Apr 9, 2020
f938714
KAFKA-9845: Emit ERROR-level log message when config provider is used…
C0urante Apr 9, 2020
1e9dae6
KAFKA-9845: Demote log message level from ERROR to WARN
C0urante Apr 10, 2020
a2f339c
KAFKA-94845: Fix failing unit tests
C0urante Apr 10, 2020
5d8af18
KAFKA-9845: Add warning message to docstring for plugin.path config
C0urante Apr 10, 2020
ccec713
KAFKA-9845: Apply suggestions from code review
C0urante Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.regex.Pattern;

import static org.apache.kafka.common.config.ConfigDef.Range.atLeast;
Expand Down Expand Up @@ -379,6 +380,20 @@ private void logDeprecatedProperty(String propName, String propValue, String def
}
}

private void logPluginPathConfigProviderWarning(Map<String, String> rawOriginals) {
String rawPluginPath = rawOriginals.get(PLUGIN_PATH_CONFIG);
String transformedPluginPath = originalsStrings().get(PLUGIN_PATH_CONFIG);
if (!Objects.equals(rawPluginPath, transformedPluginPath)) {
log.error(
Comment thread
C0urante marked this conversation as resolved.
Outdated
"Config providers do not work with the plugin.path property. The raw value '{}' "
+ "will be used for plugin scanning, as opposed to the transformed value '{}'. "
+ "See https://issues.apache.org/jira/browse/KAFKA-9845 for more information.",
Comment thread
C0urante marked this conversation as resolved.
Outdated
rawPluginPath,
transformedPluginPath
);
}
}

public Integer getRebalanceTimeout() {
return null;
}
Expand All @@ -398,6 +413,7 @@ public static List<String> pluginLocations(Map<String, String> props) {
public WorkerConfig(ConfigDef definition, Map<String, String> props) {
super(definition, props);
logInternalConverterDeprecationWarnings(props);
logPluginPathConfigProviderWarning(props);
}

private static class AdminListenersValidator implements ConfigDef.Validator {
Expand Down