HOTFIX: faile to compile HighwatermarkCheckpointBench by scala 2.13#8361
Closed
chia7712 wants to merge 1 commit into
Closed
HOTFIX: faile to compile HighwatermarkCheckpointBench by scala 2.13#8361chia7712 wants to merge 1 commit into
chia7712 wants to merge 1 commit into
Conversation
Member
Author
|
this issue is related to #6741 |
3 tasks
Member
Author
Member
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source compatibility offered by
scala-collection-compatis based on scala implicit conversions. It means the "explicit" reference in java codeHighwatermarkCheckpointBenchcan't join the party (scala.jdk.CollectionConvertersis linked to scala 2.13 code and the symbol used byHighwatermarkCheckpointBenchis gone)It seems to me we should have a collection of helper methods to offer the conversion like
scala-collection-compatand it servers for jmh java code only.This PR replaces
scala.jdk.CollectionConvertersbyscala.collection.JavaConverterssincescala.collection.JavaConvertersmethods required byHighwatermarkCheckpointBenchexists on both scala 2.12 and scala 2.13.Committer Checklist (excluded from commit message)