Skip to content

KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap. #8224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 3 commits into from
Apr 24, 2020
Merged

KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap. #8224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aee0cc8
A minor change for zOS
zshuo Mar 4, 2020
bd84ce3
Add a static keyword
zshuo Mar 5, 2020
a5847cc
Fix the identation of the curly bracket
zshuo Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clients/src/main/java/org/apache/kafka/common/utils/OperatingSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ private OperatingSystem() {

public static final boolean IS_WINDOWS;

public static final boolean IS_ZOS;

static {
NAME = System.getProperty("os.name").toLowerCase(Locale.ROOT);
IS_WINDOWS = NAME.startsWith("windows");
IS_ZOS = NAME.startsWith("z/os");
}
}
12 changes: 6 additions & 6 deletions core/src/main/scala/kafka/log/AbstractIndex.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ abstract class AbstractIndex(@volatile var file: File, val baseOffset: Long, val
try {
val position = mmap.position()

/* Windows won't let us modify the file length while the file is mmapped :-( */
if (OperatingSystem.IS_WINDOWS)
/* Windows or z/OS won't let us modify the file length while the file is mmapped :-( */
if (OperatingSystem.IS_WINDOWS || OperatingSystem.IS_ZOS)
safeForceUnmap()
raf.setLength(roundedNewSize)
_length = roundedNewSize
Expand Down Expand Up @@ -322,16 +322,16 @@ abstract class AbstractIndex(@volatile var file: File, val baseOffset: Long, val
}

/**
* Execute the given function in a lock only if we are running on windows. We do this
* because Windows won't let us resize a file while it is mmapped. As a result we have to force unmap it
* Execute the given function in a lock only if we are running on windows or z/OS. We do this
* because Windows or z/OS won't let us resize a file while it is mmapped. As a result we have to force unmap it
* and this requires synchronizing reads.
*/
protected def maybeLock[T](lock: Lock)(fun: => T): T = {
if (OperatingSystem.IS_WINDOWS)
if (OperatingSystem.IS_WINDOWS || OperatingSystem.IS_ZOS)
lock.lock()
try fun
finally {
if (OperatingSystem.IS_WINDOWS)
if (OperatingSystem.IS_WINDOWS || OperatingSystem.IS_ZOS)
lock.unlock()
}
}
Expand Down