Skip to content

MINOR: comment apikey types in generated switch #8201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 1 commit into from
Mar 15, 2020
Merged

MINOR: comment apikey types in generated switch #8201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,19 +256,21 @@ private void generateHeaderVersion(String type) {
buffer.incrementIndent();
for (Map.Entry<Short, ApiData> entry : apis.entrySet()) {
short apiKey = entry.getKey();
buffer.printf("case %d:%n", apiKey);
ApiData apiData = entry.getValue();
String name = apiData.name();
buffer.printf("case %d: // %s%n", apiKey, MessageGenerator.capitalizeFirst(name));
buffer.incrementIndent();
if (type.equals("response") && apiKey == 18) {
// ApiVersionsResponse always includes a v0 header.
// See KIP-511 for details.
buffer.printf("// ApiVersionsResponse always includes a v0 header.%n");
buffer.printf("// See KIP-511 for details.%n");
buffer.printf("return (short) 0;%n");
buffer.decrementIndent();
continue;
}
if (type.equals("request") && apiKey == 7) {
// Version 0 of ControlledShutdownRequest has a non-standard request header
// which does not include clientId. Version 1 of ControlledShutdownRequest
// and later use the standard request header.
buffer.printf("// Version 0 of ControlledShutdownRequest has a non-standard request header%n");
buffer.printf("// which does not include clientId. Version 1 of ControlledShutdownRequest%n");
buffer.printf("// and later use the standard request header.%n");
buffer.printf("if (_version == 0) {%n");
buffer.incrementIndent();
buffer.printf("return (short) 0;%n");
Expand Down