KAKFA-9612 CLI Dynamic Configuration with file input#8184
Closed
WanderingStar wants to merge 6 commits into
Closed
KAKFA-9612 CLI Dynamic Configuration with file input#8184WanderingStar wants to merge 6 commits into
WanderingStar wants to merge 6 commits into
Conversation
WanderingStar
force-pushed
the
KAFKA-9612
branch
from
March 10, 2020 17:46
eb09315 to
4e593b3
Compare
WanderingStar
force-pushed
the
KAFKA-9612
branch
from
April 1, 2020 17:25
bf1d7ee to
779c8fa
Compare
dajac
reviewed
Apr 1, 2020
dajac
left a comment
dajac
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I have left few comments.
dajac
approved these changes
Apr 8, 2020
dajac
left a comment
dajac
left a comment
Member
There was a problem hiding this comment.
@WanderingStar I just made a pass over it and it looks good to me, assuming that all the tests pass. I just left one nit.
Contributor
Author
|
@rajinisivaram, @cmccabe, @gwenshap would you mind taking a look at this PR? |
omkreddy
reviewed
Apr 25, 2020
omkreddy
left a comment
omkreddy
left a comment
Contributor
There was a problem hiding this comment.
@WanderingStar Thanks for the PR. left few comments.
also please rebase the PR.
WanderingStar
force-pushed
the
KAFKA-9612
branch
from
April 27, 2020 15:00
8b4cad0 to
f8ef1ec
Compare
Contributor
Author
|
Thanks for your review, @omkreddy! I've rebased and incorporated your feedback. |
Contributor
|
ok to test |
omkreddy
approved these changes
Apr 27, 2020
omkreddy
left a comment
omkreddy
left a comment
Contributor
There was a problem hiding this comment.
@WanderingStar Thanks for the PR. LGTM.
Contributor
|
JDK 8, 11 tests passed. JDK 14 test failures are not related. Merging to trunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to kafka-configs.sh
--add-config-filethat adds the configs from a properties file.Testing: Added new tests to ConfigCommandTest.scala
Committer Checklist (excluded from commit message)