KAFKA-9290: Update IQ related JavaDocs by highluck · Pull Request #8114 · apache/kafka

highluck · 2020-02-13T22:47:04Z

Update IQ related JavaDocs

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

mjsax · 2020-02-14T18:07:42Z

Thanks for the PR @highluck -- this overlaps with #7848 but the other PR seems to be abandoned? Hence, I would just more forward with your PR.

There are some other changes in #7848 (changing KeyValueStore to ReadOnlyKeyValueStore and adding missing generic types) -- also the class JavaDoc of KTable has a change in it. Can you include those changes in your PR?

\cc @miroswan who is the author of #7848 -- let us know if you are still interested in finishing your PR (we don't want to "take it away" from you).

miroswan · 2020-02-14T19:01:55Z

Thanks for the PR @highluck -- this overlaps with #7848 but the other PR seems to be abandoned? Hence, I would just more forward with your PR.

There are some other changes in #7848 (changing KeyValueStore to ReadOnlyKeyValueStore and adding missing generic types) -- also the class JavaDoc of KTable has a change in it. Can you include those changes in your PR?

\cc @miroswan who is the author of #7848 -- let us know if you are still interested in finishing your PR (we don't want to "take it away" from you).

@mjsax I apologize. Please feel free to reassign.

highluck · 2020-02-14T19:45:21Z

@mjsax
thanks for review

i'm update docs!

@miroswan
thanks!

highluck · 2020-02-24T07:21:45Z

@mjsax
Retest this please.

mjsax

Sorry for the review delay. LGTM! Will merge after Jenkins passed.

mjsax · 2020-04-19T18:52:01Z

Retest this please

mjsax · 2020-04-20T05:48:40Z

Build failed with checkstyle error:

[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java:34:8: Unused import - org.apache.kafka.streams.processor.ProcessorContext. [UnusedImports]
11:59:28 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java:163:21: '=' is not preceded with whitespace. [WhitespaceAround]

@highluck Can you update the PR?

highluck · 2020-04-20T12:08:01Z

Thank you for reivew
Yes ok!

highluck · 2020-04-20T14:01:06Z

@mjsax

It was a hotfix!
#8515

# Conflicts: # streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java # streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java # streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java # streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedTable.java # streams/src/main/java/org/apache/kafka/streams/kstream/KTable.java # streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedCogroupedKStream.java # streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java

ableegoldman · 2020-04-20T17:45:43Z

-     * ReadOnlyKeyValueStore<String, Long> localStore = streams.store(queryableStoreName, QueryableStoreTypes.<String, Long>keyValueStore());
-     * String key = "some-key";
-     * Long valueForKey = localStore.get(key); // key must be local (application state is shared over all running Kafka Streams instances)
+     * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore = streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>timestampedKeyValueStore());


nit: insert space between generics (here and elsewhere)

ok! thanks :)

mjsax · 2020-04-20T22:39:50Z

Ah. Thanks for pointing out the hotfix @highluck. Can you address Sophie's comment?

…java

…dStream.java

…java

…dowedCogroupedKStream.java

…dowedKStream.java

mjsax · 2020-05-08T06:15:09Z

I removed the blanks you inserted on the wrong place in a previous commit but not not remove in your latest commit.

Thanks for the PR! Merged to trunk.

highluck · 2020-05-08T06:34:28Z

@mjsax
thanks!!

* 'trunk' of github.com:apache/kafka: KAFKA-9290: Update IQ related JavaDocs (apache#8114) KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest (apache#8600) KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py (apache#8613) KAFKA-9667: Connect JSON serde strip trailing zeros (apache#8230) MINOR: Log4j Improvements on Fetcher (apache#8629)

Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <matthias@confluent.io>

highluck requested a review from mjsax February 13, 2020 22:47

mjsax added the streams label Feb 14, 2020

highluck force-pushed the timestamp-doc branch from b055acb to 46fd1bf Compare February 14, 2020 19:41

mjsax reviewed Apr 19, 2020

View reviewed changes

mjsax mentioned this pull request Apr 19, 2020

KAFKA-9243 Update the javadocs to include TimestampKeyValueStore #7848

Closed

highluck force-pushed the timestamp-doc branch from d762464 to 8cbcbe8 Compare April 20, 2020 14:20

KAFKA-9290: Update IQ related JavaDocs

82503b7

highluck force-pushed the timestamp-doc branch from 8cbcbe8 to 82503b7 Compare April 20, 2020 14:40

ableegoldman reviewed Apr 20, 2020

View reviewed changes

insert space

a11017d

mjsax reviewed May 8, 2020

View reviewed changes

Comment thread streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java Outdated

insert space

292c12a

mjsax reviewed May 8, 2020

View reviewed changes

mjsax added 7 commits May 7, 2020 23:09

Update streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.…

aa23e65

…java

Update streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.…

118120a

…java

Update streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.…

da6a3e6

…java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KGroupe…

764e8a1

…dStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KGroupe…

9f89272

…dStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KGroupe…

7d0605c

…dStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KGroupe…

ae2c47d

…dStream.java

mjsax added 14 commits May 7, 2020 23:10

Update streams/src/main/java/org/apache/kafka/streams/kstream/KGroupe…

2b7f829

…dStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KGroupe…

e7574f9

…dStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KTable.…

17ce6a5

…java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KTable.…

65d644a

…java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KTable.…

b6cd0b1

…java

Update streams/src/main/java/org/apache/kafka/streams/kstream/KTable.…

eb1321e

…java

Update streams/src/main/java/org/apache/kafka/streams/kstream/TimeWin…

6638e1e

…dowedCogroupedKStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/TimeWin…

a27ac53

…dowedCogroupedKStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/TimeWin…

771eab0

…dowedKStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/TimeWin…

cd776eb

…dowedKStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/TimeWin…

e83c73c

…dowedKStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/TimeWin…

3a578e6

…dowedKStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/TimeWin…

16a9307

…dowedKStream.java

Update streams/src/main/java/org/apache/kafka/streams/kstream/TimeWin…

ce3e9d6

…dowedKStream.java

mjsax merged commit 133c2ed into apache:trunk May 8, 2020

jwijgerd pushed a commit to buxapp/kafka that referenced this pull request May 14, 2020

KAFKA-9290: Update IQ related JavaDocs (apache#8114)

0472fd3

Reviewers: A. Sophie Blee-Goldman <sophie@confluent.io>, Matthias J. Sax <matthias@confluent.io>

Uh oh!

Conversation

highluck commented Feb 13, 2020

Committer Checklist (excluded from commit message)

Uh oh!

mjsax commented Feb 14, 2020

Uh oh!

miroswan commented Feb 14, 2020

Uh oh!

highluck commented Feb 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highluck commented Feb 24, 2020

Uh oh!

mjsax left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjsax commented Apr 19, 2020

Uh oh!

mjsax commented Apr 20, 2020

Uh oh!

highluck commented Apr 20, 2020

Uh oh!

highluck commented Apr 20, 2020

Uh oh!

ableegoldman Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

highluck Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

mjsax commented Apr 20, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mjsax commented May 8, 2020

Uh oh!

highluck commented May 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

highluck commented Feb 14, 2020 •

edited

Loading

mjsax left a comment •

edited

Loading