Skip to content

KAFKA-9206: throw a KafkaException when encountering CORRUPT_MESSAGE #8111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 7 commits into from
Feb 21, 2020
+38 −2
Merged

KAFKA-9206: throw a KafkaException when encountering CORRUPT_MESSAGE #8111

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
efa1736
KAFKA-9206: throw a KafkaException when encountering `CORRUPT_MESSAGE…
Feb 14, 2020
969295d
nit: formatting
Feb 14, 2020
a58e1be
added test
Feb 14, 2020
152323b
Review: throw away return value from fetchedRecords() in test
Feb 14, 2020
d8afd7e
Review: expanded log warnings to include fetch-offset
Feb 18, 2020
8cd5c55
Review: use "{}" in log warnings
Feb 19, 2020
238eced
Review: add reference to the CORRUPT_MESSAGE error in docs for `Fetch…
Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,11 @@ private CompletedFetch initializeCompletedFetch(CompletedFetch nextCompletedFetc
log.debug("Received unknown leader epoch error in fetch for partition {}", tp);
} else if (error == Errors.UNKNOWN_SERVER_ERROR) {
log.warn("Unknown error fetching data for topic-partition {}", tp);
} else if (error == Errors.CORRUPT_MESSAGE) {
throw new KafkaException("Encountered corrupt message when fetching offset "

@hachikuji hachikuji Feb 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, could we add the fetch offset to the IllegalStateException message below and the UNKNOWN_SERVER_ERROR log message above?

@agam agam Feb 18, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

+ fetchOffset
+ " for topic-partition "
+ tp);
} else {
throw new IllegalStateException("Unexpected error code " + error.code() + " while fetching from partition " + tp);
}
Expand Down
25 changes: 25 additions & 0 deletions clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3835,6 +3835,31 @@ public void testFetchCompletedBeforeHandlerAdded() {
assertEquals(1, fetcher.sendFetches());
}

@Test
public void testCorruptMessageError() {
buildFetcher();
assignFromUser(singleton(tp0));
subscriptions.seek(tp0, 0);

assertEquals(1, fetcher.sendFetches());
assertFalse(fetcher.hasCompletedFetches());

// Prepare a response with the CORRUPT_MESSAGE error.
client.prepareResponse(fullFetchResponse(
tp0,
buildRecords(1L, 1, 1),
Errors.CORRUPT_MESSAGE,
100L, 0));
consumerClient.poll(time.timer(0));
assertTrue(fetcher.hasCompletedFetches());

// Trigger the exception.
assertThrows(KafkaException.class, () -> {
Map<TopicPartition, List<ConsumerRecord<byte[], byte[]>>> partitionRecords =
fetchedRecords();

@soondenana soondenana Feb 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just calling fetchedRecords() should work here, or is compiler not liking it and forcing the return value assignment?

@agam agam Feb 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, made the change to discard the return value.

});
}

private MockClient.RequestMatcher listOffsetRequestMatcher(final long timestamp) {
// matches any list offset request with the provided timestamp
return new MockClient.RequestMatcher() {
Expand Down