Skip to content

KAFKA-9519: Deprecating ZK for ConfigCommand #8056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmccabe merged 3 commits into from
Feb 8, 2020
Merged

KAFKA-9519: Deprecating ZK for ConfigCommand #8056

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a7db5a
KAFKA-9519: Deprecating ZK for ConfigCommand
Feb 6, 2020
c626308
addressing PR comments
Feb 6, 2020
6a13f71
Merge branch 'trunk' into KAFKA-9519
Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/main/scala/kafka/admin/ConfigCommand.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ object ConfigCommand extends Config {
opts.checkArgs()

if (opts.options.has(opts.zkConnectOpt)) {
println(s"Warning: --zookeeper is deprecated and will be removed in a future version of Kafka.")
println(s"Use --bootstrap-server instead to specify a broker to connect to.")
processCommandWithZk(opts.options.valueOf(opts.zkConnectOpt), opts)
} else {
processCommand(opts)
Expand Down Expand Up @@ -535,8 +537,8 @@ object ConfigCommand extends Config {

class ConfigCommandOptions(args: Array[String]) extends CommandDefaultOptions(args) {

val zkConnectOpt = parser.accepts("zookeeper", "The connection string for the zookeeper connection in the form host:port. " +
"Multiple URLS can be given to allow fail-over.")
val zkConnectOpt = parser.accepts("zookeeper", "DEPRECATED. The connection string for the zookeeper connection in the form host:port. " +
Comment thread
skaundinya15 marked this conversation as resolved.
"Multiple URLS can be given to allow fail-over. Replaced by --bootstrap-server, REQUIRED unless --bootstrap-server is given.")
.withRequiredArg
.describedAs("urls")
.ofType(classOf[String])
Expand Down