KAFKA-9188; Fix flaky test SslAdminClientIntegrationTest.testSynchronousAuthorizerAclUpdatesBlockRequestThreads - #7918
Merged
rajinisivaram merged 1 commit intoJan 10, 2020
Conversation
…ousAuthorizerAclUpdatesBlockRequestThreads
omkreddy
approved these changes
Jan 10, 2020
omkreddy
left a comment
omkreddy
left a comment
Contributor
There was a problem hiding this comment.
@rajinisivaram Thanks for the PR. LGTM.
Contributor
Author
|
@omkreddy Thanks for the review. Test failures not related, merging to trunk. |
gitlw
pushed a commit
to linkedin/kafka
that referenced
this pull request
Jun 18, 2020
…ntegrationTest.testSynchronousAuthorizerAclUpdatesBlockRequestThreads (apache#7918) The test blocks requests threads while sending the ACL update requests and occasionally hits request timeout. Updated the test to tolerate timeouts and retry the request for that case. Added an additional check to verify that the requests threads are unblocked when the semaphore is released, ensuring that the timeout is not due to blocked threads. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the build failures in the JIRA, it looks like the test occasionally hits request timeout when running from Jenkins (I was able to recreate only with much smaller request timeouts). Since the test blocks requests threads while sending the ACL update requests, updated the test to tolerate timeouts and retry the request for that case. Added an additional check to verify that the requests threads are unblocked when the semaphore is released, ensuring that the timeout is not due to blocked threads.
Committer Checklist (excluded from commit message)