KAFKA-9375 Add thread names to kafka connect #7901
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.common.utils; | ||
|
|
||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.concurrent.ThreadFactory; | ||
|
|
||
| public class ThreadUtilsTest { | ||
|
|
||
| private static final Runnable EMPTY_RUNNABLE = new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| } | ||
| }; | ||
| private static final String THREAD_NAME = "ThreadName"; | ||
| private static final String THREAD_NAME_WITH_NUMBER = THREAD_NAME + "%d"; | ||
|
|
||
|
|
||
| @Test | ||
| public void testThreadNameWithoutNumberNoDemon() { | ||
| Assert.assertEquals(ThreadUtils.createThreadFactory(THREAD_NAME, false). | ||
| newThread(EMPTY_RUNNABLE).getName(), THREAD_NAME); | ||
| } | ||
|
|
||
| @Test | ||
| public void testThreadNameWithoutNumberDemon() { | ||
| Thread daemonThread = ThreadUtils.createThreadFactory(THREAD_NAME, true).newThread(EMPTY_RUNNABLE); | ||
| try { | ||
| Assert.assertEquals(daemonThread.getName(), THREAD_NAME); | ||
| Assert.assertTrue(daemonThread.isDaemon()); | ||
| } finally { | ||
| try { | ||
| daemonThread.join(); | ||
| } catch (InterruptedException e) { | ||
| // can be ignored | ||
| e.printStackTrace(); | ||
|
Member
There was a problem hiding this comment. Maybe we don't need to print the stack trace if we can ignore it |
||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testThreadNameWithNumberNoDemon() { | ||
| ThreadFactory localThreadFactory = ThreadUtils.createThreadFactory(THREAD_NAME_WITH_NUMBER, false); | ||
| Assert.assertEquals(localThreadFactory.newThread(EMPTY_RUNNABLE).getName(), THREAD_NAME + "1"); | ||
| Assert.assertEquals(localThreadFactory.newThread(EMPTY_RUNNABLE).getName(), THREAD_NAME + "2"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testThreadNameWithNumberDemon() { | ||
| ThreadFactory localThreadFactory = ThreadUtils.createThreadFactory(THREAD_NAME_WITH_NUMBER, true); | ||
| Thread daemonThread1 = localThreadFactory.newThread(EMPTY_RUNNABLE); | ||
| Thread daemonThread2 = localThreadFactory.newThread(EMPTY_RUNNABLE); | ||
|
Member
There was a problem hiding this comment. Do we need
Contributor
Author
There was a problem hiding this comment. I wanted to check if 2 daemonThreads are appropriately numbered. |
||
|
|
||
| try { | ||
| Assert.assertEquals(daemonThread1.getName(), THREAD_NAME + "1"); | ||
| Assert.assertTrue(daemonThread1.isDaemon()); | ||
| } finally { | ||
| try { | ||
| daemonThread1.join(); | ||
| } catch (InterruptedException e) { | ||
| // can be ignored | ||
| e.printStackTrace(); | ||
| } | ||
| } | ||
| try { | ||
| Assert.assertEquals(daemonThread2.getName(), THREAD_NAME + "2"); | ||
| Assert.assertTrue(daemonThread2.isDaemon()); | ||
| } finally { | ||
| try { | ||
| daemonThread2.join(); | ||
| } catch (InterruptedException e) { | ||
| // can be ignored | ||
| e.printStackTrace(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all
assertmethod, the first argument is the "expected" value while the second one is the "actual" value. Can you swap them in this file to match that definition?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acked