KAFKA-9315: The Kafka Metrics class should clear the mbeans map when closing - #7851
Closed
cmccabe wants to merge 1 commit into
Closed
KAFKA-9315: The Kafka Metrics class should clear the mbeans map when closing#7851cmccabe wants to merge 1 commit into
cmccabe wants to merge 1 commit into
Conversation
…closing The JmxReporter should clear the mbeans map when closing. Otherwise, metrics may be incorrectly re-registered if the JmxReporter class is used after it is closed. For example, calling JmxReporter#close followed by JmxReporter#unregister could result in some of the mbeans that were removed in the close operation being re-registered.
Member
|
@cmccabe is this ready for review? cc @hachikuji who reviewed the other related PR. |
Contributor
Author
|
I have a better change that I'm planning to post soon. I'll close this one. Sorry for the confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JmxReporter should clear the mbeans map when closing. Otherwise,
metrics may be incorrectly re-registered if the JmxReporter class is
used after it is closed.
For example, calling JmxReporter#close followed by
JmxReporter#unregister could result in some of the mbeans that were
removed in the close operation being re-registered.