Skip to content

KAFKA-9310: Handle UnknownProducerId from RecordCollector.send #7845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvcephei merged 2 commits into from
Dec 21, 2019
Merged

KAFKA-9310: Handle UnknownProducerId from RecordCollector.send #7845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9cb480
KAFKA-9310: Handle UnknownProducerId from RecordCollector.send
vvcephei Dec 17, 2019
4b3e86d
cr feedback
vvcephei Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,10 @@ public void onCompletion(final RecordMetadata metadata,
}
});
} catch (final RuntimeException uncaughtException) {
if (uncaughtException instanceof KafkaException &&
uncaughtException.getCause() instanceof ProducerFencedException) {
if (uncaughtException instanceof KafkaException &&(
uncaughtException.getCause() instanceof ProducerFencedException ||
uncaughtException.getCause() instanceof UnknownProducerIdException

@mjsax mjsax Dec 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message of RecoverableClientException does not match any longer... (I would recommend to not add the error name to begin with, as the root cause exception is pass into the constructor anyway)

)) {
final KafkaException kafkaException = (KafkaException) uncaughtException;
// producer.send() call may throw a KafkaException which wraps a FencedException,
// in this case we should throw its wrapped inner cause so that it can be captured and re-wrapped as TaskMigrationException
Expand Down
59 changes: 59 additions & 0 deletions streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.errors.ProducerFencedException;
import org.apache.kafka.common.errors.TimeoutException;
import org.apache.kafka.common.errors.UnknownProducerIdException;
import org.apache.kafka.common.header.Header;
import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.header.internals.RecordHeader;
Expand Down Expand Up @@ -199,6 +200,44 @@ public synchronized Future<RecordMetadata> send(final ProducerRecord record, fin
collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
}

@SuppressWarnings("unchecked")

@mjsax mjsax Dec 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this?

@vvcephei vvcephei Dec 18, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing generics in the method. I fixed it.

@Test(expected = RecoverableClientException.class)

@mjsax mjsax Dec 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should avoid to use this construct but use assertThrows() instead.

@mjsax mjsax Dec 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also verify the root cause?

public void shouldThrowRecoverableExceptionOnProducerFencedException() {
final RecordCollector collector = new RecordCollectorImpl(
"test",
logContext,
new DefaultProductionExceptionHandler(),
new Metrics().sensor("dropped-records")
);
collector.init(new MockProducer(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
@Override
public synchronized Future<RecordMetadata> send(final ProducerRecord record, final Callback callback) {
throw new KafkaException(new ProducerFencedException("asdf"));
}
});

collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
}

@SuppressWarnings("unchecked")
@Test(expected = RecoverableClientException.class)

@mjsax mjsax Dec 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

public void shouldThrowRecoverableExceptionOnUnknownProducerException() {
final RecordCollector collector = new RecordCollectorImpl(
"test",
logContext,
new DefaultProductionExceptionHandler(),
new Metrics().sensor("dropped-records")
);
collector.init(new MockProducer(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
@Override
public synchronized Future<RecordMetadata> send(final ProducerRecord record, final Callback callback) {
throw new KafkaException(new UnknownProducerIdException("asdf"));
}
});

collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
}

@SuppressWarnings("unchecked")
@Test(expected = RecoverableClientException.class)
public void shouldThrowRecoverableExceptionWhenProducerFencedInCallback() {
Expand All @@ -219,6 +258,26 @@ public synchronized Future<RecordMetadata> send(final ProducerRecord record, fin
collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
}

@SuppressWarnings("unchecked")
@Test(expected = RecoverableClientException.class)
public void shouldThrowRecoverableExceptionWhenProducerForgottenInCallback() {
final RecordCollector collector = new RecordCollectorImpl(
"test",
logContext,
new DefaultProductionExceptionHandler(),
new Metrics().sensor("skipped-records"));
collector.init(new MockProducer(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
@Override
public synchronized Future<RecordMetadata> send(final ProducerRecord record, final Callback callback) {
callback.onCompletion(null, new UnknownProducerIdException("asdf"));
return null;
}
});

collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
}

@SuppressWarnings("unchecked")
@Test
public void shouldThrowStreamsExceptionOnSubsequentCallIfASendFailsWithDefaultExceptionHandler() {
Expand Down