Skip to content

KAFKA-9310: Handle UnknownProducerId from RecordCollector.send #7845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvcephei merged 2 commits into from
Dec 21, 2019
Merged

KAFKA-9310: Handle UnknownProducerId from RecordCollector.send #7845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9cb480
KAFKA-9310: Handle UnknownProducerId from RecordCollector.send
vvcephei Dec 17, 2019
4b3e86d
cr feedback
vvcephei Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
*/
package org.apache.kafka.streams.processor.internals;

import java.util.Collections;
import org.apache.kafka.clients.producer.Callback;
import org.apache.kafka.clients.producer.Producer;
import org.apache.kafka.clients.producer.ProducerRecord;
Expand All @@ -35,8 +34,8 @@
import org.apache.kafka.common.errors.TimeoutException;
import org.apache.kafka.common.errors.UnknownProducerIdException;
import org.apache.kafka.common.errors.UnknownServerException;
import org.apache.kafka.common.metrics.Sensor;
import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.metrics.Sensor;
import org.apache.kafka.common.serialization.Serializer;
import org.apache.kafka.common.utils.LogContext;
import org.apache.kafka.streams.errors.ProductionExceptionHandler;
Expand All @@ -45,6 +44,7 @@
import org.apache.kafka.streams.processor.StreamPartitioner;
import org.slf4j.Logger;

import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -231,12 +231,10 @@ public void onCompletion(final RecordMetadata metadata,
}
});
} catch (final RuntimeException uncaughtException) {
if (uncaughtException instanceof KafkaException &&
uncaughtException.getCause() instanceof ProducerFencedException) {
final KafkaException kafkaException = (KafkaException) uncaughtException;
if (isRecoverable(uncaughtException)) {
// producer.send() call may throw a KafkaException which wraps a FencedException,
// in this case we should throw its wrapped inner cause so that it can be captured and re-wrapped as TaskMigrationException
throw new RecoverableClientException("Caught a wrapped ProducerFencedException", kafkaException);
throw new RecoverableClientException("Caught a recoverable exception", uncaughtException);
} else {
throw new StreamsException(
String.format(
Expand All @@ -252,6 +250,12 @@ public void onCompletion(final RecordMetadata metadata,
}
}

public static boolean isRecoverable(final RuntimeException uncaughtException) {
return uncaughtException instanceof KafkaException && (
uncaughtException.getCause() instanceof ProducerFencedException ||
uncaughtException.getCause() instanceof UnknownProducerIdException);
}

private void checkForException() {
if (sendException != null) {
throw sendException;
Expand Down
90 changes: 81 additions & 9 deletions streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.errors.ProducerFencedException;
import org.apache.kafka.common.errors.TimeoutException;
import org.apache.kafka.common.errors.UnknownProducerIdException;
import org.apache.kafka.common.header.Header;
import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.header.internals.RecordHeader;
Expand All @@ -54,6 +55,7 @@

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.instanceOf;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;
Expand Down Expand Up @@ -180,43 +182,113 @@ public void shouldNotAllowOffsetsToBeUpdatedExternally() {
assertThat(collector.offsets().get(topicPartition), equalTo(2L));
}

@SuppressWarnings("unchecked")
@Test(expected = StreamsException.class)
@Test
public void shouldThrowStreamsExceptionOnAnyExceptionButProducerFencedException() {
final RecordCollector collector = new RecordCollectorImpl(
"test",
logContext,
new DefaultProductionExceptionHandler(),
new Metrics().sensor("dropped-records")
);
collector.init(new MockProducer(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
collector.init(new MockProducer<byte[], byte[]>(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
@Override
public synchronized Future<RecordMetadata> send(final ProducerRecord record, final Callback callback) {
public synchronized Future<RecordMetadata> send(final ProducerRecord<byte[], byte[]> record, final Callback callback) {
throw new KafkaException();
}
});

collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
final StreamsException thrown = assertThrows(StreamsException.class, () ->
collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner)
);
assertThat(thrown.getCause(), instanceOf(KafkaException.class));
}

@SuppressWarnings("unchecked")
@Test(expected = RecoverableClientException.class)
@Test
public void shouldThrowRecoverableExceptionOnProducerFencedException() {
final RecordCollector collector = new RecordCollectorImpl(
"test",
logContext,
new DefaultProductionExceptionHandler(),
new Metrics().sensor("dropped-records")
);
collector.init(new MockProducer<byte[], byte[]>(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
@Override
public synchronized Future<RecordMetadata> send(final ProducerRecord<byte[], byte[]> record, final Callback callback) {
throw new KafkaException(new ProducerFencedException("asdf"));
}
});

final RecoverableClientException thrown = assertThrows(RecoverableClientException.class, () ->
collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner)
);
assertThat(thrown.getCause(), instanceOf(KafkaException.class));
assertThat(thrown.getCause().getCause(), instanceOf(ProducerFencedException.class));
}

@Test
public void shouldThrowRecoverableExceptionOnUnknownProducerException() {
final RecordCollector collector = new RecordCollectorImpl(
"test",
logContext,
new DefaultProductionExceptionHandler(),
new Metrics().sensor("dropped-records")
);
collector.init(new MockProducer<byte[], byte[]>(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
@Override
public synchronized Future<RecordMetadata> send(final ProducerRecord<byte[], byte[]> record, final Callback callback) {
throw new KafkaException(new UnknownProducerIdException("asdf"));
}
});

final RecoverableClientException thrown = assertThrows(RecoverableClientException.class, () ->
collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner)
);
assertThat(thrown.getCause(), instanceOf(KafkaException.class));
assertThat(thrown.getCause().getCause(), instanceOf(UnknownProducerIdException.class));
}

@Test
public void shouldThrowRecoverableExceptionWhenProducerFencedInCallback() {
final RecordCollector collector = new RecordCollectorImpl(
"test",
logContext,
new DefaultProductionExceptionHandler(),
new Metrics().sensor("skipped-records"));
collector.init(new MockProducer(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
collector.init(new MockProducer<byte[], byte[]>(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
@Override
public synchronized Future<RecordMetadata> send(final ProducerRecord record, final Callback callback) {
public synchronized Future<RecordMetadata> send(final ProducerRecord<byte[], byte[]> record, final Callback callback) {
callback.onCompletion(null, new ProducerFencedException("asdf"));
return null;
}
});

collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
final RecoverableClientException thrown = assertThrows(RecoverableClientException.class, () ->
collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner)
);
assertThat(thrown.getCause(), instanceOf(ProducerFencedException.class));
}

@Test
public void shouldThrowRecoverableExceptionWhenProducerForgottenInCallback() {
final RecordCollector collector = new RecordCollectorImpl(
"test",
logContext,
new DefaultProductionExceptionHandler(),
new Metrics().sensor("skipped-records"));
collector.init(new MockProducer<byte[], byte[]>(cluster, true, new DefaultPartitioner(), byteArraySerializer, byteArraySerializer) {
@Override
public synchronized Future<RecordMetadata> send(final ProducerRecord<byte[], byte[]> record, final Callback callback) {
callback.onCompletion(null, new UnknownProducerIdException("asdf"));
return null;
}
});

collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner);
final RecoverableClientException thrown = assertThrows(RecoverableClientException.class, () ->
collector.send("topic1", "3", "0", null, null, stringSerializer, stringSerializer, streamPartitioner)
);
assertThat(thrown.getCause(), instanceOf(UnknownProducerIdException.class));
}

@SuppressWarnings("unchecked")
Expand Down