Skip to content

DOCS - clarify transactionalID and idempotent behavior #7821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 2 commits into from
Feb 7, 2020
Merged

DOCS - clarify transactionalID and idempotent behavior #7821

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89b8d33
DOCS - clarify transactionalID and idempotent behavior
joel-hamill Dec 11, 2019
fa61ea0
feedback
joel-hamill Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public class ProducerConfig extends AbstractConfig {
/** <code> transactional.id </code> */
public static final String TRANSACTIONAL_ID_CONFIG = "transactional.id";
public static final String TRANSACTIONAL_ID_DOC = "The TransactionalId to use for transactional delivery. This enables reliability semantics which span multiple producer sessions since it allows the client to guarantee that transactions using the same TransactionalId have been completed prior to starting any new transactions. If no TransactionalId is provided, then the producer is limited to idempotent delivery. " +
"Note that <code>enable.idempotence</code> must be enabled if a TransactionalId is configured. " +
"If a TransactionalId is configured, <code>enable.idempotence</code> is implied. " +
"The default is <code>null</code>, which means transactions cannot be used. " +

@ghost ghost Dec 31, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is <code>null</code> - I don't think this is clear enough, is it talking about the default for TransactionalId or the default for enable.idempotence?

"Note that, by default, transactions require a cluster of at least three brokers which is the recommended setting for production; for development you can change this, by adjusting broker setting <code>transaction.state.log.replication.factor</code>.";

Expand Down