MINOR: Update ZooKeeper upgrade notes - #7818
Conversation
|
cc @edenhill |
There was a problem hiding this comment.
What are "testing upgrades"?
There was a problem hiding this comment.
@edenhill Thanks for the review. I have updated the statement. Please take a look.
There was a problem hiding this comment.
- "Make sure to update your local zookeeper.properties file with "enable.adminserver=false" (or whatever the property is) if you wish to disable the AdminServer."
There was a problem hiding this comment.
Can we change "ZooKeeper has been upgraded from 3.4.14 to 3.5.5" to "ZooKeeper has been upgraded from 3.4.14 to 3.5.6"?
There was a problem hiding this comment.
@ijuma Thanks for the review. Updated the docs. Please take one more look.
5879ac2 to
edcfb6d
Compare
There was a problem hiding this comment.
I'm not sure why we would ever recommend setting snapshot.trust.empty, when we know that it is buggy. We should explicitly tell them not to do this, then link to the ZK JIRA explaining why not. Then we should explain what the right solution is (downloading the blank snapshot file)
There was a problem hiding this comment.
We have observed data loss only in standalone cluster upgrades. So I have recommended snapshot.trust.empty flag for multi-node cluster clusters. I just updated the note to avoid unnecessary confusion.
@cmccabe @ijuma Can you take a look please. I would like to include above note to 2.4.0 upgrade docs..
52eba37 to
6ec8223
Compare
|
LGTM |
|
Thanks for the reviews. Merging to trunk and 2.4. |
Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Magnus Edenhill <magnus@edenhill.se>, Colin Patrick McCabe <cmccabe@apache.org> Closes #7818 from omkreddy/zk-note
Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Magnus Edenhill <magnus@edenhill.se>, Colin Patrick McCabe <cmccabe@apache.org> Closes apache#7818 from omkreddy/zk-note
4 participants
Committer Checklist (excluded from commit message)