MINOR: Simplify the timeout logic to handle protocol in Connect distributed system tests - #7806
Merged
rhauch merged 1 commit intoDec 10, 2019
Conversation
…ibuted system tests
Contributor
Author
|
Run of Connect system tests with this branch: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3627/ |
Contributor
Author
|
System test run (https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3627/) passed. |
kkonstantine
approved these changes
Dec 9, 2019
kkonstantine
left a comment
kkonstantine
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rhauch
This PR reflects the direction of the comment I wanted to leave in the previous PR but I didn't get to it soon enough. That if there's no significant difference between the two timeouts (like 4x as it used to be), let's unify them across Connect protocols.
Thus, LGTM!
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
…ibuted system tests (apache#7806)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes a very flaky system test for
sessionedprotocol. The previous code checked explicitly forcompatibleand did not work with the latestsessionedprotocol, and since this was to set the timeout it's simply easier to always set it for the longer time.Should be backported to
2.4and2.3.Increasing the timeout (see #7789) was not sufficient.
Committer Checklist (excluded from commit message)