KAFKA-9011: Removed multiple calls to supplier.get() - #7685
Merged
Conversation
…d multiple transformer instances being created.
Member
|
ping @vvcephei for second review. |
Member
|
Java 8 failed with Java 11/2.12 and Java 11/2.13 passed |
Member
|
retest this please |
Contributor
Author
|
This time these tests failed:
|
Contributor
Author
|
retest this please |
Member
|
Java 11/2.13 failed with Java 11/2.12 passed retest this please |
Member
|
Merged #7685 into trunk. |
Member
|
Thanks for the follow-up on this @kokachev! |
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
…d multiple transformer instances being created. (apache#7685) This is a followup PR for apache#7520 to address issue of multiple calls to get() as it was pointed out by @bbejeck in apache#7520 (comment) Reviewers: Bill Bejeck <bbejeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup PR for #7520 to address issue of multiple calls to get() as it was pointed out by @bbejeck in #7520 (comment)
@vvcephei
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)