Skip to content

KAFKA-9011: Removed multiple calls to supplier.get() - #7685

Merged
bbejeck merged 1 commit into
apache:trunkfrom
kokachev:flatTransformScala
Nov 14, 2019
Merged

KAFKA-9011: Removed multiple calls to supplier.get()#7685
bbejeck merged 1 commit into
apache:trunkfrom
kokachev:flatTransformScala

Conversation

@kokachev

@kokachev kokachev commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

This is a followup PR for #7520 to address issue of multiple calls to get() as it was pointed out by @bbejeck in #7520 (comment)

@vvcephei

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…d multiple transformer instances being created.

@bbejeck bbejeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up PR @kokachev. LGTM

@bbejeck

bbejeck commented Nov 13, 2019

Copy link
Copy Markdown
Member

ping @vvcephei for second review.

@bbejeck

bbejeck commented Nov 13, 2019

Copy link
Copy Markdown
Member

Java 8 failed with

kafka.api.SaslGssapiSslEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe
org.apache.kafka.streams.integration.KTableSourceTopicRestartIntegrationTest.shouldRestoreAndProgressWhenTopicWrittenToDuringRestorationWithEosEnabled

Java 11/2.12 and Java 11/2.13 passed

@bbejeck

bbejeck commented Nov 13, 2019

Copy link
Copy Markdown
Member

retest this please

@kokachev

Copy link
Copy Markdown
Contributor Author

This time these tests failed:

kafka.api.AdminClientIntegrationTest.testElectUncleanLeadersForAllPartitions
kafka.api.ConsumerBounceTest.testClose

@kokachev

Copy link
Copy Markdown
Contributor Author

retest this please

@bbejeck

bbejeck commented Nov 14, 2019

Copy link
Copy Markdown
Member

Java 11/2.13 failed with kafka.api.SaslGssapiSslEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe
Java 8 2/11 failed with kafka.api.SaslGssapiSslEndToEndAuthorizationTest.testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl

Java 11/2.12 passed

retest this please

@bbejeck
bbejeck merged commit 7f5c380 into apache:trunk Nov 14, 2019
@bbejeck

bbejeck commented Nov 14, 2019

Copy link
Copy Markdown
Member

Merged #7685 into trunk.

@bbejeck

bbejeck commented Nov 14, 2019

Copy link
Copy Markdown
Member

Thanks for the follow-up on this @kokachev!

vvcephei pushed a commit that referenced this pull request Dec 21, 2019
…d multiple transformer instances being created. (#7685)

This is a followup PR for #7520 to address issue of multiple calls to get() as it was pointed out by @bbejeck in #7520 (comment)

Reviewers: Bill Bejeck <bbejeck@gmail.com>
qq619618919 pushed a commit to qq619618919/kafka that referenced this pull request May 12, 2020
…d multiple transformer instances being created. (apache#7685)

This is a followup PR for apache#7520 to address issue of multiple calls to get() as it was pointed out by @bbejeck in apache#7520 (comment)

Reviewers: Bill Bejeck <bbejeck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants