Skip to content

KAFKA-3044: Re-word consumer.poll behaviour#751

Closed
praveend wants to merge 2 commits into
apache:trunkfrom
praveend:poll_doc_changes
Closed

KAFKA-3044: Re-word consumer.poll behaviour#751
praveend wants to merge 2 commits into
apache:trunkfrom
praveend:poll_doc_changes

Conversation

@praveend

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing articles & punctuation in this description. "not available in buffer" -> "not available in the buffer". "available currently in buffer else return empty" -> "available currently in the buffer, else return empty"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ewencp . Corrected!!

@ewencp

ewencp commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

LGTM, thanks!

@asfgit asfgit closed this in 7059158 Jan 11, 2016
AnGg98 pushed a commit to AnGg98/kafka that referenced this pull request Jul 25, 2022
With 6f81bb1 merged, we can now use c4.xlarge instances with our system tests, which are much more reliable for spot than m3.xlarge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants